Martin Panter added the comment:
inherit-doctype.v3.patch looks good to me
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Roundup Robot added the comment:
New changeset 75571407dcd3 by Serhiy Storchaka in branch '3.4':
Issue #19176: Fixed doctype() related bugs in C implementation of ElementTree.
https://hg.python.org/cpython/rev/75571407dcd3
New changeset 6ae8842e9b60 by Serhiy Storchaka in branch '3.5':
Issue
Serhiy Storchaka added the comment:
In 2.7 XMLParser is a function, not a class, and therefore can't be subclassed.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: -Python 2.7
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
versions: +Python 2.7, Python 3.4, Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Serhiy Storchaka added the comment:
Here is a patch that also fixes other issues with doctype.
1) Direct call of doctype() issues a warning.
2) Parser's doctype() is not called if target's doctype() is called.
--
Added file: http://bugs.python.org/file39820/inherit-doctype.v3.patch
Martin Panter added the comment:
Ideally I guess the Python native behaviour is better: only call
target.doctype() if available. It might allow you to easily implement doctype()
in both the old and new versions of the API, without worrying about the API
being called twice, and without
Changes by Martin Panter vadmium...@gmail.com:
--
components: +Extension Modules
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Changes by Martin Panter vadmium...@gmail.com:
--
components: +XML -Extension Modules
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Serhiy Storchaka added the comment:
Started topic on Python-Dev:
http://comments.gmane.org/gmane.comp.python.devel/153655 .
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Eli Bendersky added the comment:
I'm not sure. This is why I'm proposing asking on python-dev
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Serhiy Storchaka added the comment:
Then what to do with the discrepancy between Python and C implementations
(msg238783)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Eli Bendersky added the comment:
I don't know how important this is to really warrant removal. Removal means
potentially breaking working code when trying to run it with Python 3.5, and my
impression was that the core devs are somewhat alergic to this, at least while
the transition to Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Serhiy Storchaka added the comment:
Updated to the tip. If Eli doesn't have objections, I'll commit it.
--
Added file: http://bugs.python.org/file39391/doctype-remove.v4.patch
___
Python tracker rep...@bugs.python.org
Arfrever Frehtes Taifersar Arahesis added the comment:
Also please apply inherit-doctype.v2.patch in 3.4 branch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Martin Panter added the comment:
The difference of calling XMLParser.doctype() between the implementations is
another argument for removing it completely. With all these bugs, and no
opposition that I know of, I think it should be okay to remove the deprecated
doctype() method in 3.5.
Martin Panter added the comment:
inherit-doctype.v2.patch inverts the logic in the C module. This patch may
still be useful if people want to apply it to 3.4, or do not want to remove the
deprecated method from 3.5.
--
Added file:
Martin Panter added the comment:
doctype-remove.v3.patch includes an entry on the What’s New page.
--
Added file: http://bugs.python.org/file38757/doctype-remove.v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
Berker Peksag added the comment:
doctype-remove.v3.patch LGTM.
--
nosy: +berker.peksag
stage: patch review - commit review
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
Serhiy Storchaka added the comment:
Looks as there is yet one difference in the behavior of Python and C
implementations. In Python implementation either self.target.doctype or
self.doctype are called. But in C implementation both are called.
--
nosy: +serhiy.storchaka
stage: - patch
Martin Panter added the comment:
Here is another patch that removes the method instead, as suggested in the
review
--
Added file: http://bugs.python.org/file37490/doctype-remove.patch
___
Python tracker rep...@bugs.python.org
Arfrever Frehtes Taifersar Arahesis added the comment:
doctype-remove.patch is acceptable for both 3.4 and 3.5 or only 3.5?
If only 3.5, then please apply inherit-doctype.patch in 3.4.
--
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
Since the doctype() method doesn’t appear to be removed from the “default”
(3.5?) branch either, here is a patch that avoids the deprecation warning when
inheriting method + a test.
Hopefully this will be useful when you get some time to look at it. I’m not
Martin Panter added the comment:
Actually I am still seeing this in 3.4.0. Looks like the doctype() method was
not removed after all.
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
Eli Bendersky added the comment:
Thanks for the report, Martin. I'll take a look once I get some time
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
New submission from Martin Panter:
I am using the C version of Element Tree via the main ElementTree module. I
have subclassed XMLParser, and created my own target object. I am not that
interested in XML doctypes, but the following simplified code raises a
DeprecationWarning:
$ python3.3
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list
29 matches
Mail list logo
