[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by Brett Cannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Kyle Stanley added the comment: The latest PR-14655 moved the last file, "threaded_import_hangers.py" into the "test_importlib" directory. As far as I can tell, there's nothing else which needs to be moved there, so the issue can be closed. --

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

miss-islington added the comment: New changeset a65c977552507dd19d2cc073fc91ae22cc66bbff by Miss Islington (bot) (Kyle Stanley) in branch 'master': bpo-19696: Move threaded_import_hangers (GH-14655) https://github.com/python/cpython/commit/a65c977552507dd19d2cc073fc91ae22cc66bbff

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Kyle Stanley added the comment: Typo: The PR in the above comment should be 14655, not 14642. -- ___ Python tracker ___ ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Kyle Stanley added the comment: Opened a new PR for moving "threaded_import_hangers" to "test_importlib/" (PR-14642). This should be the final file in "tests/" to move into "test_importlib/", so the issue can be closed if this PR is merged. I'll create a new issue for modernizing the tests

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by Kyle Stanley : -- pull_requests: +14462 pull_request: https://github.com/python/cpython/pull/14655 ___ Python tracker ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by Kyle Stanley : -- pull_requests: +14454 pull_request: https://github.com/python/cpython/pull/14642 ___ Python tracker ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Kyle Stanley added the comment: Typo in previous comment: "test_threaded_imports.py" should be "test_threaded_import.py". -- ___ Python tracker ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Kyle Stanley added the comment: In order to avoid the merge conflicts, I'm going to move test_threaded_imports.py and threaded_import_hangers.py in separate PRs. Here's the PR for moving test_threaded_imports.py https://github.com/python/cpython/pull/14582. --

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by Kyle Stanley : -- pull_requests: +14401 pull_request: https://github.com/python/cpython/pull/14582 ___ Python tracker ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

miss-islington added the comment: New changeset 56ec4f1fdedd5b38deb06d94d51dd1a540262e90 by Miss Islington (bot) (Kyle Stanley) in branch 'master': bpo-19696: Replace deprecated method in "test_import_pkg.py" (GH-14466)

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Kyle Stanley added the comment: Created a new PR for moving the last two files "test_threaded_import.py" and "threaded_import_hangers.py" to the directory "test_importlib". (https://github.com/python/cpython/pull/14537) There were some issues with automatically merging the changes, was the

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by Kyle Stanley : -- pull_requests: +14350 pull_request: https://github.com/python/cpython/pull/14537 ___ Python tracker ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: Created a new PR replacing the deprecated method "random.choose" with "random.choice" in "test_pkg_import.py" (https://github.com/python/cpython/pull/14466). -- ___ Python tracker

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by aeros167 : -- pull_requests: +14283 pull_request: https://github.com/python/cpython/pull/14466 ___ Python tracker ___ ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: > Thanks for the PR, aeros167! BTW, if you want to open a new issue and > modernize the tests to use importlib directly that would be great! Sounds good, I'll definitely look into doing that after finishing up this issue. Was waiting the previous PR to be merged

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Brett Cannon added the comment: Thanks for the PR, aeros167! BTW, if you want to open a new issue and modernize the tests to use importlib directly that would be great! -- ___ Python tracker

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

miss-islington added the comment: New changeset 80097e089ba22a42d804e65fbbcf35e5e49eed00 by Miss Islington (bot) (Kyle Stanley) in branch 'master': bpo-19696: Moved "test_pkgimport.py" to dir "test_importlib" (GH-14303)

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: Created a PR for moving and renaming "test_pkimport". An initial approval was made, now it is awaiting core review (https://github.com/python/cpython/pull/14303). -- ___ Python tracker

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by aeros167 : -- keywords: +patch pull_requests: +14127 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14303 ___ Python tracker

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: > Yep, just make sure the tests still pass before and after the change. :) Sounds good, the first thing I had done before proposing the change was testing it in an IDE and using some logging to ensure that random.choose and random.choice were providing the same

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Brett Cannon added the comment: > Would it be appropriate to change the "choose" method to "choice"? Yep, just make sure the tests still pass before and after the change. :) > should the name of "test_pkgimport" instead be "test_pkg_import"? Since things are moving it's fine to rename the

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: Decided to start working on this issue, seems like a solid starting point. After submitting a minor doc contribution, I wanted to also attempt to contribute to some of the easier enhancement requests. >From my current assessment, it appears that

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Brett Cannon added the comment: Anything zipimport-related should stay separate as zipimport is not a part of importlib. The other three will have to be looked at to see what exactly they are testing to know whether they relate to importlib and the implementation of import or not (my guess

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Gil Forcada Codinachs added the comment: At least test_namespace_pkgs is already moved, see https://bugs.python.org/issue21097 Should then this issue be closed? I see that there are a few other tests that have import on its name and are outside either test_import or test_importlib: -

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19696 ___

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

New submission from Brett Cannon: E.g. test_namespace_pkgs should be under test_importlib and so should test_namespace_pkgs. test_import can conceivably stay out if it's updated to only contain syntactic tests for the import statement. This is so that it's easier to run import-related tests

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Eric Snow added the comment: +1 -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19696 ___ ___ Python-bugs-list mailing list