[issue19717] resolve() fails when the path doesn't exist

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Philip Ridout : -- nosy: +Philip Ridout ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Marcel Plch : -- pull_requests: +1930 ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Donald Stufft : -- pull_requests: +830 ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Steve Dower : -- status: open -> closed ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Steve Dower : -- stage: commit review -> resolved ___ Python tracker ___

[issue19717] resolve() fails when the path doesn't exist

Guido van Rossum added the comment: Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19717] resolve() fails when the path doesn't exist

Roundup Robot added the comment: New changeset 03bbee2b0d28 by Steve Dower in branch '3.6': Issue #19717: Makes Path.resolve() succeed on paths that do not exist (patch by Vajrasky Kok) https://hg.python.org/cpython/rev/03bbee2b0d28 New changeset 445415e402be by Steve Dower in branch

[issue19717] resolve() fails when the path doesn't exist

Steve Dower added the comment: Applied. I changed the default for the parameter and updated the docs, but the rest is as in the patch. -- assignee: -> steve.dower resolution: -> fixed stage: -> commit review ___ Python tracker

[issue19717] resolve() fails when the path doesn't exist

Guido van Rossum added the comment: I'd be very happy if that landed in 3.6 with the default strict=False. -- ___ Python tracker ___

[issue19717] resolve() fails when the path doesn't exist

Steve Dower added the comment: Anyone have any major concerns with add_non_strict_resolve_pathlib_v4.patch? I'd be quite happy without adding the extra parameter to Path.resolve(), but I'm not strongly offended. >From Guido's email we should default to strict=False (i.e. don't throw if the

[issue19717] resolve() fails when the path doesn't exist

Guido van Rossum added the comment: Please make sure this lands in beta 4! --Guido (mobile) -- ___ Python tracker ___

[issue19717] resolve() fails when the path doesn't exist

Martin Wagner added the comment: i have a use-case that requires a behavior that is referenced above as --canonicalize-missing. essentially i need to get rid of relative parts in a path representation regardless the actual filesystem. my conclusion was that PurePath could provide that with a

[issue19717] resolve() fails when the path doesn't exist

Changes by Steve Dower : -- nosy: +steve.dower ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Brett Cannon : -- priority: normal -> deferred blocker ___ Python tracker ___

[issue19717] resolve() fails when the path doesn't exist

Brett Cannon added the comment: Guido has kept his opinion that it should resolve until the path no longer exists and then just stop: https://mail.python.org/pipermail/python-ideas/2016-September/042203.html -- nosy: +brett.cannon ___ Python

[issue19717] resolve() fails when the path doesn't exist

Serhiy Storchaka added the comment: I have written a patch that implements all three mode for posixpath.realpath() (issue27002). Having the implementation we can test and research it. After discussion this solution can be adopted for Path.resolve(). -- versions: +Python 3.6 -Python

[issue19717] resolve() fails when the path doesn't exist

Changes by Davide Rizzo : -- nosy: +davide.rizzo ___ Python tracker ___ ___

[issue19717] resolve() fails when the path doesn't exist

Changes by July Tikhonov july.t...@gmail.com: -- nosy: +july ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19717 ___ ___ Python-bugs-list mailing

[issue19717] resolve() fails when the path doesn't exist

Antoine Pitrou added the comment: Well, given the diversity of possible behaviours, it starts to seem like it should maybe be discussed on python-dev. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19717

[issue19717] resolve() fails when the path doesn't exist

Vajrasky Kok added the comment: I based my implementation on this statement: Guido pointed out that it may more useful to resolve the path components until one doesn't exist until one doesn't exist in this case means P(BASE, 'foo', 'in', 'spam') resolves until BASE / 'foo'. If different

[issue19717] resolve() fails when the path doesn't exist

Serhiy Storchaka added the comment: I believe Guido meant one of standard strategies. Current posixpath.realpath() implementation conforms --canonicalize-missing. It is not clear which two strategies (from three) should be used in Path.resolve(). --

[issue19717] resolve() fails when the path doesn't exist

Vajrasky Kok added the comment: Updated patch to tip. Later, I refactor Windows code to make sure it does not loop forever. -- Added file: http://bugs.python.org/file33171/add_non_strict_resolve_pathlib_v4.patch ___ Python tracker

[issue19717] resolve() fails when the path doesn't exist

Serhiy Storchaka added the comment: Vajrasky's patch implements fourth strategy, which is not conform neither --canonicalize nor --canonicalize-missing. Path(BASE, 'foo', 'in', 'spam') is resolved to Path(BASE, 'foo'). I doubt that this is most expected behavior. --

[issue19717] resolve() fails when the path doesn't exist

Vajrasky Kok added the comment: Here is the patch with Windows support. I notice there is difference regarding resolving symbolic link with parent dir (linkA/..) between Posix and Windows. On Windows, if linkY points to dirB, 'dirA\linkY\..' resolves to 'dirA' without resolving linkY first.

[issue19717] resolve() fails when the path doesn't exist

Changes by Vajrasky Kok sky@speaklikeaking.com: Removed file: http://bugs.python.org/file33089/add_non_strict_resolve_pathlib_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19717 ___

[issue19717] resolve() fails when the path doesn't exist

Changes by Vajrasky Kok sky@speaklikeaking.com: Added file: http://bugs.python.org/file33090/add_non_strict_resolve_pathlib_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19717 ___

[issue19717] resolve() fails when the path doesn't exist

Serhiy Storchaka added the comment: I think a patch in issue19887 first should be committed. It totally rewrites resolve(). -- dependencies: +Path.resolve() fails on complex symlinks ___ Python tracker rep...@bugs.python.org

[issue19717] resolve() fails when the path doesn't exist

Vajrasky Kok added the comment: Thanks for the review, Antoine! Here is the updated patch. I haven't tested it on Windows yet because I want to clarify one thing. Let's say we have this valid directory: /tmp/@test123 = directory And this directory only has one valid file:

[issue19717] resolve() fails when the path doesn't exist

Serhiy Storchaka added the comment: The readlink utility has different modes for canonization: -f, --canonicalize canonicalize by following every symlink in every component of the given name recursively; all but the last component must exist -e,

[issue19717] resolve() fails when the path doesn't exist

Antoine Pitrou added the comment: I think every mode has use cases. Probably, but which ones are the most likely? A ternary flag leads to a clumsier API than a simple binary flag. -- ___ Python tracker rep...@bugs.python.org

[issue19717] resolve() fails when the path doesn't exist

Antoine Pitrou added the comment: (note that POSIX realpath() fails with ENOENT if the file doesn't exist: http://pubs.opengroup.org/onlinepubs/9699919799/functions/realpath.html ) -- ___ Python tracker rep...@bugs.python.org

[issue19717] resolve() fails when the path doesn't exist

Guido van Rossum added the comment: Hm, so we can choose to be more like POSIX realpath() or more like os.path.realpath(). I guess your original intuition was right. Close with no action is fine. If I need a partial real path I can always crawl up parents() until I find a path that does

[issue19717] resolve() fails when the path doesn't exist

Antoine Pitrou added the comment: I think there's value in allowing the less strict behaviour with an optional arg, though. i.e.: Path('toto').resolve() Traceback (most recent call last): File stdin, line 1, in module File /home/antoine/cpython/default/Lib/pathlib.py, line 1024, in

[issue19717] resolve() fails when the path doesn't exist

Guido van Rossum added the comment: Sure. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19717 ___ ___ Python-bugs-list mailing list

[issue19717] resolve() fails when the path doesn't exist

Vajrasky Kok added the comment: Here is the preliminary patch. Only tested on Linux. Later I'll test it on Windows. -- keywords: +patch nosy: +vajrasky Added file: http://bugs.python.org/file32947/add_non_strict_resolve_pathlib.patch ___ Python

[issue19717] resolve() fails when the path doesn't exist

New submission from Antoine Pitrou: Currently Path.resolve() raises FileNotFoundError when the path does not exist. Guido pointed out that it may more useful to resolve the path components until one doesn't exist, and then return the rest unchanged. e.g. if /home/ points to /var/home/,