Roundup Robot added the comment:
New changeset 4a1fe339dcf6 by Serhiy Storchaka in branch 'default':
Issue #19980: Improved help() for non-recognized strings. help('') now
https://hg.python.org/cpython/rev/4a1fe339dcf6
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
There is a problem with the patch. When you are in interactive help utility,
then the request 'help' runs nested interactive help utility. The difference
between unpatched behavior is that now you need press Ctrl-D or 'q' twice to
exit to normal Python
Mark Lawrence added the comment:
LGTM.
I noticed this running the tests.
test_modules (test.test_pydoc.PydocImportTest) ... skipped 'causes undesireable
side-effects (#20128)'
test_modules_search (test.test_pydoc.PydocImportTest) ... skipped 'causes
undesireable side-effects (#20128)'
Serhiy Storchaka added the comment:
Thank you for your contribution Mark.
I noticed this running the tests.
This is temporary OK.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file38279/issue19880v4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file38278/issue19880v4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
Mark Lawrence added the comment:
Pang :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Lawrence added the comment:
Ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Lawrence added the comment:
I screwed up, sorry folks. If the latest patch isn't correct I give up as it's
three strikes and I'm out :(
--
Added file: http://bugs.python.org/file37565/issue19880v3.diff
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
Did I test the last patch? I would hope so but I simply can't remember as it's
nearly four months ago, sorry :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
Zachary Ware added the comment:
In that case, it would be good to make sure it still applies and passes the
tests. Last time I tried it didn't, and I was called away before I could
leave a note to that effect (for which I am sorry). However, I don't have
a strong enough opinion on this issue
Mark Lawrence added the comment:
Anybody?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Zachary Ware added the comment:
Mark, did you test your latest patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Mark Lawrence added the comment:
ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Mark Lawrence added the comment:
I suppose that technically this can only go into 3.5, but is there any real
reason that this couldn't be backported?
--
versions: +Python 3.5 -Python 3.4
Added file: http://bugs.python.org/file36141/Issue19980.diff
Zachary Ware added the comment:
Mark, would you like to update your patch to address my review comments?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
Mark Lawrence added the comment:
Can somebody set the stage to patch review and give my patch the once over
please, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Mark Lawrence added the comment:
Please find attached a first pass at a patch file. Help('') produces help for
the str class as discussed. I found the difference between help('help') and
help() very confusing. The former produced the help output but left you at the
interactive prompt, the
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list
Mark Lawrence added the comment:
Anybody?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Jessica McKellar added the comment:
@BreamoreBoy, thanks for following up on this!
I propose the following. help('') returns help on strings in the same way
that help([]) and help({}) returns help on lists and dicts respectively,
Sounds good.
further help(''.method) returns help on the
Mark Lawrence added the comment:
I propose the following. help('') returns help on strings in the same way that
help([]) and help({}) returns help on lists and dicts respectively, further
help(''.method) returns help on the string method or an attribute error, so
this appears to me
Elias Zamaria added the comment:
Sorry for the late response but I have been busy with various things. I may
be able to work on this but I don't know when or how long it will take me.
I would suggest that someone else work on it if anyone wants it done any
time soon. I am sorry about this.
On
Jessica McKellar added the comment:
Elias, thanks for your patch!
I think it's important to add the second part of Terry's suggestion which gives
the user a specific next step to take, namely:
Try help('help') for information on recognized strings or help(str) for help
on the str class.
Terry J. Reedy added the comment:
help() uses lib/pydoc.py and pydoc tests are in test/test_pydoc.py
I think tests for things help does that pydoc does not do (help on topics?)
should be in site.py.
--
___
Python tracker rep...@bugs.python.org
Elias Zamaria added the comment:
Here is a patch that addresses the empty string problem described by
@BreamoreBoy. I am not sure if this is the best way to handle it but it is
better than what we have now.
--
Added file: http://bugs.python.org/file34281/empty-help-response.patch
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Elias Zamaria added the comment:
I have created a patch that fixes this issue that terry.reedy described. It
does not fix the problem described BreamoreBoy involving the empty string.
Please note that this is my first patch for Python so let me know if I am
missing something or if I can do
New submission from Terry J. Reedy:
help(1)
# help on int
help(b'a')
# help on bytes
help('a')
no Python documentation found for 'a'
The reason for this unhelpful response is that strings are treated differently
from all other non-class objects. (msg205861 thought this a bug.) The strings
Mark Lawrence added the comment:
IMHO this must be changed.
help('')
# nothing!!!
help('a')
Help on module a:
...
I happened to have a module called a.py in the default directory.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
32 matches
Mail list logo
