Roundup Robot added the comment:
New changeset df81f9b67736 by R David Murray in branch 'default':
#20098: add mangle_from_ policy option.
https://hg.python.org/cpython/rev/df81f9b67736
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Thanks, Milan.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Milan Oberkirch added the comment:
Updated the last patch according to the review comments at
https://bugs.python.org/review/20098/.
--
Added file: http://bugs.python.org/file35020/mangle_from_20140424.patch
___
Python tracker rep...@bugs.python.org
Changes by Milan Oberkirch milan...@oberkirch.org:
Added file: http://bugs.python.org/file35021/mangle_from_20140424.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file35020/mangle_from_20140424.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Steve Holden added the comment:
This is an easy issue?
--
nosy: +holdenweb
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
___
Milan Oberkirch added the comment:
Added documentation for mangle_from. since the name mangle_from_ is not
supported by the markup, changed it to mangle_from everywhere, which looks
better anyway (I understand why it was the other way so). If it was a bad idea,
I can undo it but am unable to
Milan Oberkirch added the comment:
Rollback to mangle_from_, sorry for the noise.
--
Added file: http://bugs.python.org/file34321/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file34320/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Changes by Milan Oberkirch milan...@oberkirch.org:
Added file: http://bugs.python.org/file34322/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file34321/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Milan Oberkirch added the comment:
(@r.david.murray) I just implemented what you suggested:
- Policy has a mangle_from_ property, overridden in EMailPolicy
- Generator and DecodedGenerator default to policy.mangle_from_ or True if
policy is None.
Would be glad if it helps :)
--
nosy:
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file34275/mangle_from.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
___
Milan Oberkirch added the comment:
Updates patch to include necessary changes to test_policy.py.
--
Added file: http://bugs.python.org/file34277/mangle_from.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Gennadiy Zlobin added the comment:
I created the patch, please review it.
--
keywords: +patch
nosy: +gennad
Added file: http://bugs.python.org/file33293/20098.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
R. David Murray added the comment:
Sorry, my message wasn't clear. The current default needs to remain the same.
What needs to be added is email.policy.Policy.mange_from, which should be True
in the compat32 policy and False in EmailPolicy. Then it needs to be hooked up
the Generator, so
New submission from R. David Murray:
I missed this. It still defaults to True in Generator. It should default to
False in the new policies (but True in compat32).
--
components: email
keywords: easy
messages: 207116
nosy: barry, r.david.murray
priority: normal
severity: normal
stage:
18 matches
Mail list logo