[issue20438] inspect: Deprecate getfullargspec?

Change by Hugo van Kemenade : -- nosy: +hugovk nosy_count: 11.0 -> 12.0 pull_requests: +26990 pull_request: https://github.com/python/cpython/pull/28618 ___ Python tracker ___

[issue20438] inspect: Deprecate getfullargspec?

Nick Coghlan added the comment: New changeset 0246422b974b1a0c50dd30b0e1a1138674ef87a5 by Nick Coghlan (Berker Peksag) in branch '3.5': bpo-28814: Undeprecate inadvertently deprecated inspect functions. (#122) (#244)

[issue20438] inspect: Deprecate getfullargspec?

Nick Coghlan added the comment: New changeset 2197eac6104311472f200645bc844adb46444b10 by Nick Coghlan (Berker Peksag) in branch '3.6': bpo-28814: Undeprecate inadvertently deprecated inspect functions. (#122) (#243)

[issue20438] inspect: Deprecate getfullargspec?

Changes by Berker Peksag : -- pull_requests: +207 ___ Python tracker ___ ___

[issue20438] inspect: Deprecate getfullargspec?

Changes by Berker Peksag : -- pull_requests: +209 ___ Python tracker ___ ___

[issue20438] inspect: Deprecate getfullargspec?

Berker Peksag added the comment: New changeset 0899b9809547ec2894dcf88cf4bba732c5d47d0d by Berker Peksag in branch 'master': bpo-28814: Undeprecate inadvertently deprecated inspect functions. (#122) https://github.com/python/cpython/commit/0899b9809547ec2894dcf88cf4bba732c5d47d0d --

[issue20438] inspect: Deprecate getfullargspec?

Changes by Matthias Bussonnier : -- pull_requests: +84 ___ Python tracker ___

[issue20438] inspect: Deprecate getfullargspec?

Nick Coghlan added the comment: Noting for the record, as the general way of querying an unbound method for the name of the first parameter and adding it to the bound arguments: def add_instance_arg(callable, bound_args): try: self = callable.__self__ func =

[issue20438] inspect: Deprecate getfullargspec?

Vedran Čačić added the comment: > Also, it is worth noting, that Signature API does not provide 100% of functionality that deprecated APIs have. It is important to do a soft deprecation of outdated APIs in 3.5 to gather users feedback, and improve Signature object. Well, here is a feedback

[issue20438] inspect: Deprecate getfullargspec?

R. David Murray added the comment: Please open a new issue for that observation/request. -- ___ Python tracker ___

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: > This is the situation I am in: coverage.py uses getargspec in a very simple > way in its tooling. I support 2.7 and 3.5, so I have to do this: try: getargspec = inspect.getfullargspec except AttributeError: getargspec =

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: > The thing is, we've adopted a policy that if something exists in python2.7 we > shouldn't delete it in python3 until after 2.7 is officially out of > maintenance (at the earliest), in order to facilitate single-source porting > to python3. That policy was

[issue20438] inspect: Deprecate getfullargspec?

R. David Murray added the comment: The thing is, we've adopted a policy that if something exists in python2.7 we shouldn't delete it in python3 until after 2.7 is officially out of maintenance (at the earliest), in order to facilitate single-source porting to python3. That policy was adopted

[issue20438] inspect: Deprecate getfullargspec?

Ned Batchelder added the comment: This is the situation I am in: coverage.py uses getargspec in a very simple way in its tooling. I support 2.7 and 3.5, so I have to do this: try: getargspec = inspect.getfullargspec except AttributeError: getargspec =

[issue20438] inspect: Deprecate getfullargspec?

Ned Batchelder added the comment: I'm confused: the discussion here is mostly about updating docs to note deprecation. Then at the very end, is an off-hand remark about removing getargspec. The docs for getargspec currently read, "This function will be removed in Python 3.6." Why? We keep

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: > The docs for getargspec currently read, "This function will be removed in > Python 3.6." Why? We keep all sorts of old APIs for the sake of backward > compatibility, why is this one different? getargspec was deprecated since 3.0. Besides that, it returns

[issue20438] inspect: Deprecate getfullargspec?

Markus Unterwaditzer added the comment: It should be properly noted that the API isn't going to be actually removed anytime soon. Also I think issuing a warning about this was a mistake. For software that wants to stay compatible with both Python 2 and 3 it's basically useless. --

[issue20438] inspect: Deprecate getfullargspec?

Markus Unterwaditzer added the comment: My last comment was in reference to getfullargspec, which is, as far as I understand, not going to be deprecated until after 3.7. -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: I'm copying/pasting my latest commit message on this issue here: Add a note about deprecating old inspect APIs to whatsnew. Also, deprecate formatargspec, formatargvalues, and getargvalues functions. Since we are deprecating 'getfullargspec' function in 3.5

[issue20438] inspect: Deprecate getfullargspec?

Berker Peksag added the comment: Just a minor comment on the patch: +warnings.warn(inspect.getargspec() is deprecated, + use inspect.signature() instead, DeprecationWarning) Can you also add stacklevel=2? -- nosy: +berker.peksag

[issue20438] inspect: Deprecate getfullargspec?

Roundup Robot added the comment: New changeset 666e5b554f32 by Yury Selivanov in branch 'default': Issue 20438: Adjust stacklevel of inspect.getargspec() warning. https://hg.python.org/cpython/rev/666e5b554f32 -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: Thanks Berker! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list

[issue20438] inspect: Deprecate getfullargspec?

Roundup Robot added the comment: New changeset 621e98bfc74b by Yury Selivanov in branch 'default': Issue 20438: Add a note about deprecating old inspect APIs to whatsnew. https://hg.python.org/cpython/rev/621e98bfc74b -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Changes by Yury Selivanov yseliva...@gmail.com: -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___

[issue20438] inspect: Deprecate getfullargspec?

Roundup Robot added the comment: New changeset 3a5fec5e025d by Yury Selivanov in branch 'default': Issue 20438: Deprecate inspect.getargspec() and friends. https://hg.python.org/cpython/rev/3a5fec5e025d -- nosy: +python-dev ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: Please see the new patch. So it's time to deprecate getargspec with a warning (was softly deprecated in 3.0). getfullargspec() and getcallargs() deprecation is documented. I also want to deprecate formatargspec() and formatargvalues(), but Signature does

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: @Larry Hasting: If you check my patch, it's the case where I modify the documentation and add a DeprecationWarning in the code. @Yury Selivanov, @Nick Coghlan, @Brett Cannon: From your point of views, I need to propose a patch just for the documentation, I

[issue20438] inspect: Deprecate getfullargspec?

Larry Hastings added the comment: +1 to doc deprecation and adding a DeprecationWarning for 3.5. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: In this patch, I deprecate the inspect.getfullargspec function in the documentation and raise an warnings.warn with DeprecationWarning. Need feedback, because the inspect.getargspec() informs the user that it can use the getfullargspec() and I think we

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: Here is the output of my test: ./python3.5 -Wd test.py test.py:9: DeprecationWarning: Deprecated warnings.warn('Deprecated', DeprecationWarning) /private/tmp/python/lib/python3.5/inspect.py:955: DeprecationWarning: Use inspect.signature() instead of

[issue20438] inspect: Deprecate getfullargspec?

Brett Cannon added the comment: I was thinking about suggesting we don't code deprecate getfullargspec() but the function seems to be new to Python 3 and so that worry for Python 2/3 code is not founded. -- ___ Python tracker rep...@bugs.python.org

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: How about we deprecate with a warning getfullargspec(); deprecate getargspec() in docs only (in 3.6 we'll fully deprecate all function parameters API except Signature)? -- ___ Python tracker rep...@bugs.python.org

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: Just one thing, how do you work for the deprecation? 1. you deprecate in the doc for 3.5? 2. you deprecate in the code for 3.6? 3. you remove the code in 3.7? What's the strategy in this case or in general? Thanks --

[issue20438] inspect: Deprecate getfullargspec?

Brett Cannon added the comment: How warnings are handled vary from case to case. Typically its documentation-only if we want to warn people that they shouldn't use something because there is a better alternative but the code is not fundamentally broken and its in Python 2. If there is

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: ok, so in this case, I can only change the documentation with a .. deprecated:. But for the future, how can we know we have to deprecate this function for = 3.6 ? Will you parse the documentation and check there is an deprecation to add in the code? Or is

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: I'd +1 for: 1. Deprecating getfullargsspec in docs; 2. Deprecating getargspec in docs and code (since it's an ancient and outdated API) Brett? -- ___ Python tracker rep...@bugs.python.org

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: Brett, If you agree with Yury, I will provide a patch with these tasks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___

[issue20438] inspect: Deprecate getfullargspec?

Brett Cannon added the comment: Since getfullargspec is new in Python 3 and inspect.signature fundamentally improves things in Python 3 due to Argument Clinic I would say go ahead and code deprecate getfullargspec (we can do a DeprecationWarning for 3.5 and 3.6 and remove in 3.7; people

[issue20438] inspect: Deprecate getfullargspec?

Stéphane Wirtel added the comment: Need your feedback for this patch Thank you -- Added file: http://bugs.python.org/file34890/issue20438_deprecate_inspect_getfullargspec-2.patch ___ Python tracker rep...@bugs.python.org

[issue20438] inspect: Deprecate getfullargspec?

Nick Coghlan added the comment: Note that getargspec() depends on getfullargspec() so deprecating the latter *will* cause issues for single-source code (unless they switch to using the funcsigs backport). -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: Nick, good catch. OK, let's just deprecate it in the docs for 3.5, so people (hopefully) will not write new code with it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438

[issue20438] inspect: Deprecate getfullargspec?

New submission from Yury Selivanov: Should we finally deprecate getfullargspec? With the AC and positional-only parameters support, getfullargspec doesn't provide full information anymore. By deprecation I mean changing its existing note Consider using the new Signature Object interface,

[issue20438] inspect: Deprecate getfullargspec?

Brett Cannon added the comment: Although I say do it in 3.5. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list

[issue20438] inspect: Deprecate getfullargspec?

Brett Cannon added the comment: I vote deprecation with no stated plans of removal -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___

[issue20438] inspect: Deprecate getfullargspec?

Nick Coghlan added the comment: As Brett said - let's do a documented deprecation in 3.5. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___

[issue20438] inspect: Deprecate getfullargspec?

Changes by Yury Selivanov yselivanov...@gmail.com: -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___