[issue20491] textwrap: Non-breaking space not honored

Changes by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20491] textwrap: Non-breaking space not honored

Changes by Donald Stufft : -- pull_requests: +1067 ___ Python tracker ___ ___

[issue20491] textwrap: Non-breaking space not honored

Roundup Robot added the comment: New changeset fcabef0ce773 by Serhiy Storchaka in branch '3.5': Issue #20491: The textwrap.TextWrapper class now honors non-breaking spaces. https://hg.python.org/cpython/rev/fcabef0ce773 New changeset bfa400108fc5 by Serhiy Storchaka in branch '3.6': Issue

[issue20491] textwrap: Non-breaking space not honored

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue20491] textwrap: Non-breaking space not honored

Serhiy Storchaka added the comment: The code of the textwrap module was changed since publishing the last patch. Proposed patch resolves conflicts and addresses Eric's comments. Maybe add breaking Unicode spaces (OGHAM SPACE MARK, EN QUAD, etc) to _whitespace? I think in future we should

[issue20491] textwrap: Non-breaking space not honored

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___

[issue20491] textwrap: Non-breaking space not honored

Changes by R. David Murray : -- versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4 ___ Python tracker ___

[issue20491] textwrap: Non-breaking space not honored

R. David Murray added the comment: It probably just got forgotten. If you want to help move it forward please do a review of the patch (see https://docs.python.org/devguide/tracker.html#reviewing-patches), including whether or not all outstanding review comments have been addressed, and post

[issue20491] textwrap: Non-breaking space not honored

Johannes Bauer added the comment: Hey there, wanted to follow up on the state of this... is there a reason why this has not made it into vanilla yet? If so, I'd like to try to help out clear impediments if I can. This issue is *really*, really, really annoying me. I've posted about a year

[issue20491] textwrap: Non-breaking space not honored

Matt Chaput added the comment: Patch on top of dbudinova's that attempts to replace the concatenation of strings with a verbose regex. -- nosy: +maatt Added file: http://bugs.python.org/file34827/issue20491_verbose.patch ___ Python tracker

[issue20491] textwrap: Non-breaking space not honored

dani added the comment: changed honor-non-breaking-spaces.patch: used \N{NO-BREAK SPACE} instead of \xa0 added test for \N{NARROW NO-BREAK SPACE} -- nosy: +dbudinova Added file: http://bugs.python.org/file34497/new_textwrap.patch ___ Python tracker

[issue20491] textwrap: Non-breaking space not honored

Éric Araujo added the comment: Thank you, this looks really good. I left some comments on rietveld. -- stage: test needed - patch review versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491

[issue20491] textwrap: Non-breaking space not honored

Éric Araujo added the comment: NON-BREAKING SPACE and NARROW NON-BREAKING SPACE are characters whose intent is clear and who are used by knowledgeable users and smart software, for example LibreOffice with an fr_FR locale. I don’t know about the other characters listed by Serhiy, and I

[issue20491] textwrap: Non-breaking space not honored

Serhiy Storchaka added the comment: What about other spaces: '\N{OGHAM SPACE MARK}', '\N{EN QUAD}', '\N{EM QUAD}', '\N{EN SPACE}', '\N{EM SPACE}', '\N{THREE-PER-EM SPACE}', '\N{FOUR-PER-EM SPACE}', '\N{SIX-PER-EM SPACE}', '\N{FIGURE SPACE}', '\N{PUNCTUATION SPACE}', '\N{THIN SPACE}', '\N{HAIR

[issue20491] textwrap: Non-breaking space not honored

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Unicode nosy: +benjamin.peterson, ezio.melotti, haypo, lemburg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491 ___

[issue20491] textwrap: Non-breaking space not honored

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491 ___ ___ Python-bugs-list

[issue20491] textwrap: Non-breaking space not honored

Éric Araujo added the comment: Using a multiline regex (with re.VERBOSE) would also avoid the clutter of parens and quotes. -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491

[issue20491] textwrap: Non-breaking space not honored

Serhiy Storchaka added the comment: It looks to me that code can be a little more clear if use C-style formatting. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491 ___

[issue20491] textwrap: Non-breaking space not honored

Changes by Kaarle Ritvanen kaarle.ritva...@datakunkku.fi: Added file: http://bugs.python.org/file33911/honor-non-breaking-spaces.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491 ___

[issue20491] textwrap: Non-breaking space not honored

Changes by Kaarle Ritvanen kaarle.ritva...@datakunkku.fi: Added file: http://bugs.python.org/file33890/textwrap-honor-non-breaking-spaces.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491

[issue20491] textwrap: Non-breaking space not honored

New submission from Kaarle Ritvanen: The textwrap module does not distinguish non-breaking space (\xa0) from other whitespace when determining word boundaries. In the beginning of the module, the _whitespace variable is defined to address this issue but is not used in the regular expressions

[issue20491] textwrap: Non-breaking space not honored

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +georg.brandl, serhiy.storchaka stage: - test needed versions: +Python 2.7 -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20491

[issue20491] textwrap: Non-breaking space not honored

Antoine Pitrou added the comment: Thanks for the patch, Kaarle. Could you add some tests in Lib/test/test_textwrap? Also, for your contribution to be integrated, we'll need you to sign a contributor's agreement: http://www.python.org/psf/contrib/contrib-form/ -- nosy: +pitrou