[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by Ned Deily : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.4, Python 3.5, Python 3.6 ___ Python tracker

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Pierre Quentel added the comment: Now that the PR has been merged, can someone close the issue ? -- ___ Python tracker ___ ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

miss-islington added the comment: New changeset 99f0e81f43f64b83e18e8cb2a0b66c53a81a74ab by Miss Islington (bot) in branch '3.7': bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (GH-10638)

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

miss-islington added the comment: New changeset e3bd941e4e6f4465f17a0e5a4a6bdf4ea0afdd0d by Miss Islington (bot) in branch '3.8': bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (GH-10638)

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by miss-islington : -- pull_requests: +15561 pull_request: https://github.com/python/cpython/pull/15920 ___ Python tracker ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by miss-islington : -- pull_requests: +15560 pull_request: https://github.com/python/cpython/pull/15919 ___ Python tracker ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Benjamin Peterson added the comment: New changeset 2d7cacacc310b65b43e7e2de89e7722291dea6a4 by Benjamin Peterson (Pierre Quentel) in branch 'master': bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (#10638)

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Pierre Quentel added the comment: I have submitted PR #10638 to fix this issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by Pierre Quentel : -- pull_requests: +9885 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by Pierre Quentel : -- pull_requests: +9881 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by Pierre Quentel : -- nosy: +quentel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by Matthias Urlichs : -- versions: +Python 3.7, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Matthias Urlichs added the comment: Owch, yeah, this fell off the radar. Anyway, I've signed the CLA, so if somebody could finish and apply this I'd be grateful. Myself, I unfortunately don't have the time. -- ___ Python tracker

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Paul Goins (work) added the comment: I'm just going to ping on this issue. It looks like this has just slipped off the radar. I've seen the last diff and the code review, but it seems that this just needs some final follow-up on the code review comments, no? I could easily do the final

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

STINNER Victor added the comment: I reviewed issue20504.diff on Rietveld. -- ___ Python tracker ___ ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

STINNER Victor added the comment: See also issue #24764: "cgi.FieldStorage.read_multi ignores Content-Length" (changeset 11e9f34169d1). -- ___ Python tracker

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Berker Peksag added the comment: The attached patch(cgi.patch) doesn't fix the problem for me: cgi-bug.py still fails with a TypeError. Here is a patch with a test to fix the problem. With issue20504.diff applied: $ ./python t.py 5 (Only changed the "assert len(fields["my-arg"].file.read())

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Sebastian Rittau added the comment: Is there any progress on this? The fix seems trivial. -- ___ Python tracker ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Matthias Urlichs added the comment: Actually, the problem is cgi.py around line 550: clen = -1 if 'content-length' in self.headers: try: clen = int(self.headers['content-length']) except ValueError: pass if

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Matthias Urlichs added the comment: Patch attached. -- keywords: +patch Added file: http://bugs.python.org/file35551/cgi.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20504 ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Matthias Urlichs added the comment: This also applies to 3.4 and 3.5. -- versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20504 ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Ned Deily added the comment: Thanks for the report, the test case, and the patch. It would be helpful if the informal test could be turned into a patch as a formal test in Lib/test_cgi.py and if, Matthias, you would be willing to sign the PSF contributor agreement if you haven't already

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Changes by Sebastian Rittau srit...@jroger.in-berlin.de: -- type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20504 ___ ___

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

New submission from Sebastian Rittau: Consider the attached test case. This test will run fine with Python 2.7, but will fail with Python 3.3. If cgi.FieldStorage() tries to parse a multipart request without a Content-Length header in the main section, segments will have a length of 0.