[issue20928] xml.etree.ElementInclude does not include nested xincludes

miss-islington added the comment: New changeset 1220a4707966679d15a9b5f7596ddd06bb4d5f23 by Miss Islington (bot) in branch '3.9': bpo-33187: Document 3.9 changes to xml.etree.ElementInclude.include (GH-20438) https://github.com/python/cpython/commit/1220a4707966679d15a9b5f7596ddd06bb4d5f23

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Change by miss-islington : -- nosy: +miss-islington nosy_count: 9.0 -> 10.0 pull_requests: +19932 pull_request: https://github.com/python/cpython/pull/20722 ___ Python tracker

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: New changeset 301f0d4ff9b6bd60599eea0612904f65a92e6dd9 by Shantanu in branch 'master': bpo-33187: Document 3.9 changes to xml.etree.ElementInclude.include (GH-20438) https://github.com/python/cpython/commit/301f0d4ff9b6bd60599eea0612904f65a92e6dd9

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 8.0 -> 9.0 pull_requests: +19695 pull_request: https://github.com/python/cpython/pull/20438 ___ Python tracker ___

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: I think setting "xml:base" from ElementInclude is worth another ticket. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.8 ___ Python tracker

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: New changeset c6a7bdb356835c9d7513b1ea6846683d446fe6c3 by Stefan Behnel in branch 'master': bpo-20928: support base-URL and recursive includes in etree.ElementInclude (#5723) https://github.com/python/cpython/commit/c6a7bdb356835c9d7513b1ea6846683d446fe6c3

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: PR is complete now, ready for merging. -- ___ Python tracker ___

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: There seems to be no documentation currently for ElementInclude. Would be nice if someone who's interested in this feature could take the time to write something up. I created a documentation ticket as issue #33187. --

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: I've added a 'max_depth' argument to limit the maximum recursive include depth to 6 by default (which is a small, arbitrarily chosen value). Users can set it to None to disable the limit. >From my side, I don't see any more features that

[issue20928] xml.etree.ElementInclude does not include nested xincludes

ruffsl added the comment: > Included file paths should be collected only along an inclusion path and not > across independent subtrees. Yes, well put. > Maybe we should add a "max_depth" parameter to limit the maximum recursion > depth, defaulting to e.g. 5, that users

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: > The check may miss infinite recursions if the hrefs happen to be written in > non-matching but equivalent forms. Ex: relative versus absolute paths. I thought about that, too, but it's not a real problem. There are only a few different

[issue20928] xml.etree.ElementInclude does not include nested xincludes

James Bailey added the comment: Agreed with ruffsl's concerns about the overly aggressive detection of infinite recursion. I also wonder if the hrefs should be normalized or canonized for the check? The check may miss infinite recursions if the hrefs happen to be

[issue20928] xml.etree.ElementInclude does not include nested xincludes

ruffsl added the comment: Hello @scoder, Thanks for looking into this. In addition to what I mentioned with lxml's use of the parent xml file's respect dirname when attempting to open the include element's href, do you think it would be possible to (optionally or by

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Change by Stefan Behnel : -- pull_requests: +5508 stage: -> patch review ___ Python tracker ___

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: The latest "fixed2" patch looks good to me, but the author didn't sign a contributors agreement. However, I did, and I already wrote the same thing for lxml, so I put together an initial PR. -- type: behavior -> enhancement

[issue20928] xml.etree.ElementInclude does not include nested xincludes

ruffsl added the comment: I see it's been a few years, but I would still like to see xml.etree.ElementInclude support nested xincludes, as lxml does. Additionally, I'd like to have the default_loader attempt to open the href with respect to the original xml file's

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: Your code adds a lot of new code. Why is that necessary? Can't the new feature be integrated into the existing code? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20928

[issue20928] xml.etree.ElementInclude does not include nested xincludes

R. David Murray added the comment: Yeah, include should now be a very simple wrapper around a call to _include, include shouldn't have the original include code (which is moved to _include) in it. -- ___ Python tracker rep...@bugs.python.org

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Blake Hartstein added the comment: That would make sense. Please see if the updated patch file works. -- Added file: http://bugs.python.org/file35783/issue20928_fixed2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20928

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Blake Hartstein added the comment: This patch incorporates nested includes and a testcase that shows how it handles infinite include by throwing an exception. -- nosy: +urule99 Added file: http://bugs.python.org/file35728/issue20928_fixed.patch ___

[issue20928] xml.etree.ElementInclude does not include nested xincludes

R. David Murray added the comment: Since there is no guarantee anyone is going to tackle the job of reviewing all the changes for whatsnew entries, I prefer that we get in the habit of creating the entries as we go along. As for the versionchanged...if you can find where include is

[issue20928] xml.etree.ElementInclude does not include nested xincludes

R. David Murray added the comment: Thanks Caelyn. This patch also needs a doc patch and a whatsnew entry in order to be complete. It's not obvious to me where the relevant documentation is, though, so perhaps we instead have missing documentation that should be addressed in a separate

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Raymond Hettinger added the comment: FWIW, we often do whatsnew entries later in the development cycle. I think this can go forward without whatsnew. The doc entry could be as simple as a ..versionchanged 2.5 include() now supports recursive Xincludes or somesuch. -- nosy:

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Caelyn McAulay added the comment: xml.etree.ElementInclude.include now checks the inserted subtree to see if contains any Xincludes itself. And adds them. Also added a unit test to check for the new functionality (which will fail without the change to ElementInclude.py). -- keywords:

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Stefan Behnel added the comment: Agreed that this should be done. The XInclude spec suggests that the processing is transitive. Also, lxml does it that way, in both the libxml2 based implementation and the ElementInclude compatibility module.

[issue20928] xml.etree.ElementInclude does not include nested xincludes

New submission from James Bailey: After xml.etree.ElementInclude.include inserts an Xinclude'd href it does not walk the just-inserted subtree to see if it contains any Xincludes itself. I think the behaviour should be modified to walk the included subtree and perform any Xincludes contained.

[issue20928] xml.etree.ElementInclude does not include nested xincludes

Changes by Ned Deily n...@acm.org: -- nosy: +eli.bendersky, scoder ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20928 ___ ___ Python-bugs-list