[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: This was pull #12. Am I correct in thinking that all the merges Serhiy did after for pull #13 included the null merge for this? -- ___ Python tracker

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: The pull requests are numbered by creation order, not by merge order. Normally I'd expect that yes, Serhiy's merge would include yours. But it didn't work out that way. If you look at the changeset graph: https://bitbucket.org/larry/cpython350/commits/all

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: Since your merge contains the changes that Serhiy already merged, I expect that there will be some conflicts. If so, the only thing I would know to do is revert and make mine and his null merges. If that is correct, will do. Making merge clone now.

[issue21192] Idle: Print filename when running a file from editor

Roundup Robot added the comment: New changeset 09cd7d57b080 by Terry Jan Reedy in branch '3.5': Issue #21192: Change 'RUN' back to 'RESTART' when running editor file. https://hg.python.org/cpython/rev/09cd7d57b080 -- ___ Python tracker

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: There won't be conflicts with Serhiy's merge--just the opposite. His pull request was merged first, so it's perfect that he did his forward merge first. He's already resolved any conflicts with his merge, and so when you merge you'll only have to worry

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: I was wrong, no conflicts. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: On the other hand, I do not hold with marking a minor cosmetic change like this as "release blocker". I'm willing to accept the change, given PEP 434, but I'm not going to delay any releases for it. -- priority: release blocker -> normal

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: Sorry, my memory was that I was supposed to that as a signal, but maybe that was with a different RM. -- ___ Python tracker

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: Terry, if you want this pulled in to Python 3.5.0, you'll need to create a pull request on Bitbucket. Instructions are here: https://mail.python.org/pipermail/python-dev/2015-August/141167.html and here:

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: On 9/3/2015 4:31 AM, Larry Hastings wrote: > Terry, if you want this pulled in to Python 3.5.0, you'll need to create a > pull request on Bitbucket. Instructions are here: > > https://mail.python.org/pipermail/python-dev/2015-August/141167.html I don't

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: https://bitbucket.org/larry/cpython350/pull-requests/12/issue-21192-change-run-back-to-restart/diff -- ___ Python tracker

[issue21192] Idle: Print filename when running a file from editor

Larry Hastings added the comment: Pull request accepted, please forward-merge. Thanks! > There is something odd about the size of your clone. My cpython > clone is 928 MB on disk with 30300 files, while the clone of my fork > of your repository is 1.59 GB for 14500 files. I have no idea why.

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: Larry, please pull @restart.diff into 3.5.0. I have already applied it to 2.7, 3.4, 3.5.1, and 3.6, so I will null merge from 3.5.0 into 3.5.1 and 3.6. Reason. Aside from Raymond's request above, I was reminded about a week ago that a) when Idle runs in one

[issue21192] Idle: Print filename when running a file from editor

Roundup Robot added the comment: New changeset 69ea73015132 by Terry Jan Reedy in branch '2.7': Issue #21192: Change 'RUN' back to 'RESTART' when running editor file. https://hg.python.org/cpython/rev/69ea73015132 New changeset 130a3edcac1d by Terry Jan Reedy in branch '3.4': Issue #21192:

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: Now that Larry Hastings has posted directions for handling changes pulled into 3.5.0, I will soon commit the attached, or something close, and add a pull request. -- keywords: +patch Added file: http://bugs.python.org/file40278/@restart.diff

[issue21192] Idle: Print filename when running a file from editor

Raymond Hettinger added the comment: I've found this to be a serious usability regression and think it should be reverted right-away. It makes IDLE unsuitable for evening showing turtle demos to kids. For adults in my classes, it was also confusing because unlike the old restart-bar it

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: How about 'RESTART: Shell' and 'RESTART: name of file' to make it clear that old definitions are forgotten in both cases while new definitions are added in the second case. I do not understand the comment about turtledemo as it runs separately from Idle.

[issue21192] Idle: Print filename when running a file from editor

Roundup Robot added the comment: New changeset edf9bfe36ad0 by Terry Jan Reedy in branch '2.7': Issue #21192: acks for 2.7 https://hg.python.org/cpython/rev/edf9bfe36ad0 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21192

[issue21192] Idle: Print filename when running a file from editor

Roundup Robot added the comment: New changeset 20a8e5dccf66 by Terry Jan Reedy in branch '2.7': Issue #21192: Idle Editor. When a file is run, put its name in the restart bar. https://hg.python.org/cpython/rev/20a8e5dccf66 New changeset 2ae12789dcb8 by Terry Jan Reedy in branch '3.4': Issue

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: This is how restarts look now. Thanks for the initial idea and patch. == RUN C:\Programs\Python34\tem.py = === RESTART Shell = -- resolution: - fixed

[issue21192] Idle: Print filename when running a file from editor

Adnan Umer added the comment: I tried to replace RESTART by doing these little changing # PyShell.Py class ModifiedInterpreter(InteractiveInterpreter): def restart_subprocess(self, with_cwd=False, with_msg=True): ... if with_msg: halfbar = ((int(console.width) -

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: I took another look and tried the patch and discovered that my comments are partly wrong because restart_shell is called before runcode when runcode is use to run a file. (I am not sure how it is called otherwise with self.tkconsole.executing == True.) This

[issue21192] Idle: Print filename when running a file from editor

Terry J. Reedy added the comment: I have not tried your patch yet, but the relevant code seems to be class ModifiedInterpreter(InteractiveInterpreter): def runcode(self, code): if code.co_filename[0] != '': ## your patch self.tkconsole.write('Executing ' +

[issue21192] Idle: Print filename when running a file from editor

Adnan Umer added the comment: Method: runcode Class: ModifiedInterpreter Line: 752 Added if code.co_filename[0] != '': self.tkconsole.write('Executing ' + code.co_filename + '\n') To print file path that is executed -- nosy: +Adnan.Umer versions: +Python 3.4 Added file:

[issue21192] Idle: Print filename when running a file from editor

New submission from Terry J. Reedy: Upon restarting the user process, Idle prints a separator bar in the shell: == RESTART= When restart is due to running a file with F5, print RUN filename instead of RESTART. Idea from Adnan Umer,

[issue21192] Idle: Print filename when running a file from editor

Changes by Adnan Umer adnanume...@gmail.com: -- components: +IDLE ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21192 ___ ___ Python-bugs-list