[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Berker Peksag added the comment: Thanks for the patch, Alex! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Roundup Robot added the comment: New changeset 91d3022b3f03 by Berker Peksag in branch '3.5': Issue #21250: Add tests for SQLite's ON CONFLICT clause https://hg.python.org/cpython/rev/91d3022b3f03 New changeset db2bedd5c34a by Berker Peksag in branch 'default': Issue #21250: Merge from 3.5

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Berker Peksag added the comment: Thanks for the patch Alex. Some quick review comments: * We need to skip SqliteOnConflictTests if the installed sqlite3 doesn't support the feature * There is no need to duplicate https://www.sqlite.org/lang_conflict.html in every test. You can add it to

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Changes by Gerhard Häring g...@ghaering.de: -- assignee: - ghaering ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21250 ___ ___ Python-bugs-list

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Changes by Raúl Cumplido raulcumpl...@gmail.com: -- nosy: +raulcd ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21250 ___ ___ Python-bugs-list

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Alex Lord added the comment: I've added a set of tests which test the insert or [algorithm] branch of sqlite. It took some getting used to python.sqlite3's transaction model but I think I have a much better understanding now. -- keywords: +patch Added file:

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Changes by Alex Lord lostdogs...@gmail.com: -- components: +Library (Lib) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21250 ___ ___

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

New submission from Alex Lord: In Lib/sqlite3/tests/dbapi.py there are no unit tests which test out sqlite3's 'insert or [algorithm].' These algorithms are also referred to as SQL 'insert on conflict.' More details at, https://www.sqlite.org/lang_conflict.html Not having unit tests for these

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Ned Deily added the comment: Are you interested in submitting a patch? -- nosy: +ghaering, ned.deily stage: - needs patch versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21250

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

Alex Lord added the comment: Yes, I'm going to work on one after I fix Issue16864 today. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21250 ___