[issue22021] shutil.make_archive() root_dir do not work

Lysandros Nikolaou added the comment: Since GH-10367 is now merged, should we close this? -- ___ Python tracker ___ ___

[issue22021] shutil.make_archive() root_dir do not work

miss-islington added the comment: New changeset 12dfbae2ec30e7c90499129b17b6049bfd9bb2b6 by Miss Islington (bot) in branch '3.8': bpo-22021: Update root_dir and base_dir documentation in shutil (GH-10367) https://github.com/python/cpython/commit/12dfbae2ec30e7c90499129b17b6049bfd9bb2b6

[issue22021] shutil.make_archive() root_dir do not work

miss-islington added the comment: New changeset be5ed59e29106634a0d02d96ed35fb71ed61cb6d by Miss Islington (bot) in branch '3.9': bpo-22021: Update root_dir and base_dir documentation in shutil (GH-10367) https://github.com/python/cpython/commit/be5ed59e29106634a0d02d96ed35fb71ed61cb6d

[issue22021] shutil.make_archive() root_dir do not work

miss-islington added the comment: New changeset d5489a964fadc028c7086218702daf6fae087340 by Miss Islington (bot) in branch '3.7': bpo-22021: Update root_dir and base_dir documentation in shutil (GH-10367) https://github.com/python/cpython/commit/d5489a964fadc028c7086218702daf6fae087340

[issue22021] shutil.make_archive() root_dir do not work

Change by miss-islington : -- pull_requests: +19927 pull_request: https://github.com/python/cpython/pull/20712 ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

Change by miss-islington : -- pull_requests: +19925 pull_request: https://github.com/python/cpython/pull/20710 ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

Change by miss-islington : -- pull_requests: +19926 pull_request: https://github.com/python/cpython/pull/20711 ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

Change by miss-islington : -- pull_requests: +19924 pull_request: https://github.com/python/cpython/pull/20709 ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

miss-islington added the comment: New changeset 7633371dace67aaa21eb4b86f889441571ec4167 by Lysandros Nikolaou in branch 'master': bpo-22021: Update root_dir and base_dir documentation in shutil (GH-10367) https://github.com/python/cpython/commit/7633371dace67aaa21eb4b86f889441571ec4167

[issue22021] shutil.make_archive() root_dir do not work

Cheryl Sabella added the comment: @giampaolo.rodola, no problem. I intended this more as a general request rather than something for right now. If you do have any availability at some point, please keep this one in mind. Thanks! -- ___ Python

[issue22021] shutil.make_archive() root_dir do not work

Giampaolo Rodola' added the comment: @cheryl.sabella don't have the bandwidth right now (traveling), sorry. -- ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

Cheryl Sabella added the comment: @giampaolo.rodola, would you be able to provide a review of this doc change? Thanks! -- nosy: +cheryl.sabella, giampaolo.rodola versions: -Python 3.6 ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

Lysandros Nikolaou added the comment: Pinging once more for review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue22021] shutil.make_archive() root_dir do not work

Lysandros Nikolaou added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22021] shutil.make_archive() root_dir do not work

Change by Lysandros Nikolaou : -- pull_requests: +9668 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue22021] shutil.make_archive() root_dir do not work

Tobias Kunze added the comment: Yes, this is a documentation issue: A patch clarifying what root_dir and base_dir do, and how they interact (or how they are to be used in combination) would be sufficient to close this issue. -- ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

Lysandros Nikolaou added the comment: Since Serhiy said that this is a pure documentation issue, I thought that a doc PR is all that was needed, which I would be happy to make. Am I missing something here? -- ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

STINNER Victor added the comment: > Is anybody working on this or can I submit a PR? Yes: Joannah Nanjekye wrote PR 10191 (from Issue22021.patch) which has been rejected. This issue is more complex from what it looks. -- ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

Lysandros Nikolaou added the comment: Is anybody working on this or can I submit a PR? -- nosy: +lys.nikolaou ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

Serhiy Storchaka added the comment: This is a documentation issue. -- stage: patch review -> needs patch versions: +Python 3.7, Python 3.8 -Python 3.5 ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

STINNER Victor added the comment: FYI. Joannah Nanjekye converted Issue22021.patch into a PR: PR 10191. Serhiy Storchaka closed the PR: "The current behavior looks correct to me. It is consistent with the behavior of the tar command. This change breaks tests and I think it will break user

[issue22021] shutil.make_archive() root_dir do not work

Change by Joannah Nanjekye : -- pull_requests: +9509 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue22021] shutil.make_archive() root_dir do not work

Change by Berker Peksag : -- nosy: -berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22021] shutil.make_archive() root_dir do not work

R. David Murray added the comment: Sounds reasonable to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue22021] shutil.make_archive() root_dir do not work

Tobias Kunze added the comment: Thank you, that's what I figured out later last evening. To my understanding, the docs don't give any indication that base_dir is supposed to be relative to root_dir, so I'd add this information, and maybe add a similar example to the one above, if that's

[issue22021] shutil.make_archive() root_dir do not work

bananaappletw added the comment: I think this snippet might help you. shutil.make_archive(base_name='/tmp/issue22021archive', format='zip', root_dir='/tmp/issue22021/root/', base_dir='structure/content/') unzip -l /tmp/issue22021archive.zip Archive: /tmp/issue22021archive.zip Length

[issue22021] shutil.make_archive() root_dir do not work

Tobias Kunze added the comment: I'm similarly confused by this issue. If somebody can help me understand what's going on, I'll put my understanding into a documentation patch. I have created this minimal example to demonstrate what I don't understand: I've created a directory structure

[issue22021] shutil.make_archive() root_dir do not work

bananaapple added the comment: I am sorry. I understand now. Thank you. -- ___ Python tracker ___ ___

[issue22021] shutil.make_archive() root_dir do not work

R. David Murray added the comment: "base_name is the name of the file to create, including the path". So you should be able to specify the path to where you want it created. If that doesn't work, that's a bug. -- ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

bananaapple added the comment: Hello Berker Peksag, 1. For now, I realize the comment of David. This is not a bug of make_archive() implementation. However, I think documentation is not clear to understand at the first time reading it. Maybe it should be rephrased. 2. Actually, what I am

[issue22021] shutil.make_archive() root_dir do not work

Changes by Berker Peksag : -- versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

Serhiy Storchaka added the comment: Agree with David, this is working as designed (and matching the behavior of say "tar -C"). But the documentation is not clear if not confusing. -- nosy: +serhiy.storchaka ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

Berker Peksag added the comment: Hi bananaapple, there are two things that need to be addressed: 1. We need to decide whether this is a bug in make_archive() implementation or not. See msg223572 and msg223668 for details. I personally agree with David's analysis in msg223668. We can rephrase

[issue22021] shutil.make_archive() root_dir do not work

bananaapple added the comment: Or, Is there anything I could help? I am glad to help fixing this issue. -- ___ Python tracker ___

[issue22021] shutil.make_archive() root_dir do not work

bananaapple added the comment: Sorry to bother. But This patch is still not accepted. I still suffer this issue. Is anyone willing to review this patch? Thanks -- nosy: +bananaapple ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

Weinan Li added the comment: that sounds reasonable -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22021 ___ ___ Python-bugs-list mailing list

[issue22021] shutil.make_archive() root_dir do not work

R. David Murray added the comment: The point *should* be that if you have something like: /home/me/some/directory/my/stuff/a /home/me/some/directory/my/stuff/b /home/me/some/other/directory and you set rootdir to '/home/me/some' and base_dir='/home/me/some/directory/my' then the file

[issue22021] shutil.make_archive() root_dir do not work

New submission from Weinan Li: set root_dir do not work output: = Python 3.4.0 (v3.4.0:04f714765c13, Mar 16 2014, 19:25:23) [MSC v.1600 64 bit (AMD64)] on win32 Type copyright, credits or license() for more information. import shutil

[issue22021] shutil.make_archive() root_dir do not work

Ezio Melotti added the comment: Thanks for the report, do you want to provide a patch? (You can check the devguide if you need more information.) -- keywords: +easy nosy: +ezio.melotti, hynek, tarek stage: - needs patch ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

R. David Murray added the comment: I believe this is working as designed, although the documentation does not make that clear. root dir is the root directory of the *created archive*, it has nothing to do with where the archive file itself is placed. -- assignee: - docs@python

[issue22021] shutil.make_archive() root_dir do not work

Weinan Li added the comment: I don't think so. In source code, it just change work dir to root_dir, do nothing, and then the change word dir back. If it works as design, the root_dir will be meaningless. should be remove. -- ___ Python tracker

[issue22021] shutil.make_archive() root_dir do not work

Weinan Li added the comment: Here's the path -- keywords: +patch Added file: http://bugs.python.org/file36022/Issue22021.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22021 ___

[issue22021] shutil.make_archive() root_dir do not work

Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22021 ___ ___ Python-bugs-list