[issue22578] Add additional attributes to re.error

2014-12-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9711c60e3049 by Serhiy Storchaka in branch 'default': Removed unused function linecol() (added in issue #22578 by mistake). https://hg.python.org/cpython/rev/9711c60e3049 -- ___ Python tracker

[issue22578] Add additional attributes to re.error

2014-11-10 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22578 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22578] Add additional attributes to re.error

2014-11-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 292c4d853662 by Serhiy Storchaka in branch 'default': Issue #22578: Added attributes to the re.error class. https://hg.python.org/cpython/rev/292c4d853662 -- nosy: +python-dev ___ Python tracker

[issue22578] Add additional attributes to re.error

2014-11-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 07f082b200a7 by Serhiy Storchaka in branch 'default': Fixed IDLE tests after changing re error messages (issue #22578). https://hg.python.org/cpython/rev/07f082b200a7 -- ___ Python tracker

[issue22578] Add additional attributes to re.error

2014-11-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Ezio for your review. -- assignee: - serhiy.storchaka resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22578

[issue22578] Add additional attributes to re.error

2014-10-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Synchronized with the tip after issue19380 changes. -- Added file: http://bugs.python.org/file36860/re_error_attrs4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22578

[issue22578] Add additional attributes to re.error

2014-10-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Matthew for your suggestions. Here is updated patch. -- Added file: http://bugs.python.org/file36852/re_error_attrs3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22578

[issue22578] Add additional attributes to re.error

2014-10-08 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- title: Add addition attributes to re.error - Add additional attributes to re.error ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22578 ___

[issue22578] Add additional attributes to re.error

2014-10-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: Sounds ok, but it would be nice to add some tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22578 ___

[issue22578] Add additional attributes to re.error

2014-10-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sounds ok, but it would be nice to add some tests. Thank you. Here is a patch with added test. -- Added file: http://bugs.python.org/file36836/re_error_attrs2.patch ___ Python tracker rep...@bugs.python.org

[issue22578] Add additional attributes to re.error

2014-10-08 Thread Matthew Barnett
Matthew Barnett added the comment: I prefer to include the line and column numbers if it's a multi-line pattern, not just if the line number is 1. BTW, it's shorter if you do this: self.colno = pos - pattern.rfind(newline, 0, pos) If there's no newline, .rfind will return -1.