Martin Panter added the comment:
I opened Issue 23738 about my problem with the new signature, so it does not
get forgotten.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
Alex Shkop added the comment:
Fixed default values for fcntl(), ioctl() and lockf()
--
Added file: http://bugs.python.org/file38598/issue22832_v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
Martin Panter added the comment:
I object to dropping the brackets from the function signatures. Now it gives
the impression that the functions accept keyword arguments:
ioctl(fd, request, arg=0, mutate_flag=True)
but:
ioctl(0, 0, bytearray(), mutate_flag=False)
Traceback (most recent call
Berker Peksag added the comment:
I object to dropping the brackets from the function signatures. Now it gives
the impression that the functions accept keyword arguments:
See issue 21488 for a similar confusion.
--
nosy: +berker.peksag
___
Python
Changes by Brett Cannon br...@python.org:
--
assignee: docs@python - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
___
Serhiy Storchaka added the comment:
This is worth a discussion on Python-Dev.
http://comments.gmane.org/gmane.comp.python.devel/152025
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
Serhiy Storchaka added the comment:
Thanks you for your patch Alex.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
Roundup Robot added the comment:
New changeset a3c9c2c92b87 by Serhiy Storchaka in branch 'default':
Issue #22832: Tweaked parameter names for fcntl module to better match
https://hg.python.org/cpython/rev/a3c9c2c92b87
--
nosy: +python-dev
___
Python
Serhiy Storchaka added the comment:
Except brackets the patch LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
___
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
___
Python-bugs-list
Alex Shkop added the comment:
This patch fixes pointed out bugs in documentation and docstring for ioctl()
function.
--
Added file: http://bugs.python.org/file38295/issue22832_v2.patch
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
The patch LGTM. Serhiy, you have anything to add?
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
Serhiy Storchaka added the comment:
I found a lot of not related issues in the documentation.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
___
Alex Shkop added the comment:
Looks like default value for mutate_flag in ioctl() should be False. Docstring
says:
If the argument is a mutable buffer and the mutable_flag argument is not
passed or is false, the behavior is as if a string had been passed.
Should I change the default value or
Alex Shkop added the comment:
Docs say that mutate_flag is true by default since Python 2.5. Looks like I
should fix the docstring.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
Alex Shkop added the comment:
Created a patch. It renames arguments in clinic declarations and in documents.
For lockf I've chosen Linux naming, because it really calls fcntl which has an
argument called cmd, not function.
--
keywords: +patch
nosy: +ashkop
Added file:
New submission from Brett Cannon:
http://bugs.python.org/review/20152/ is filled with various suggestions from
Serhiy on how to update the function parameters in the fcntl module to more
closely match what is in the man pages. This should be fully
backwards-compatible as the parameters are
17 matches
Mail list logo
