STINNER Victor added the comment:
An assertion failed in _Py_read() while running test_signal on AMD64 Snow Leop
3.x:
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/2779/steps/test/logs/stdio
[321/393/1] test_signal
Assertion failed: (errno == EINTR
Roundup Robot added the comment:
New changeset 6dd201b6bb4f by Victor Stinner in branch 'default':
Issue #23708: Split assertion expression in two assertions in _Py_read() and
https://hg.python.org/cpython/rev/6dd201b6bb4f
--
___
Python tracker
STINNER Victor added the comment:
Same error on x86 Tiger 3.x buildbot:
http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/9381/steps/test/logs/stdio
[345/393] test_signal
Python/fileutils.c:1181: failed assertion `errno == EINTR PyErr_Occurred()'
Fatal Python error: Aborted
STINNER Victor added the comment:
New changeset 07fd54208434 by Victor Stinner in branch 'default':
Issue #23708: Save/restore errno in _Py_read() and _Py_write()
When I wrote _Py_read()/_Py_write(), I added assertions on errno to ensure that
errno is not modified. I chose to use assertions
Roundup Robot added the comment:
New changeset 07fd54208434 by Victor Stinner in branch 'default':
Issue #23708: Save/restore errno in _Py_read() and _Py_write()
https://hg.python.org/cpython/rev/07fd54208434
--
___
Python tracker
Roundup Robot added the comment:
New changeset 116e4c40115f by Victor Stinner in branch 'default':
Issue #23708: Fix _Py_read() compilation error on Windows
https://hg.python.org/cpython/rev/116e4c40115f
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset c3c47ea32f72 by Victor Stinner in branch 'default':
Issue #23708: Add _Py_read() and _Py_write() functions to factorize code handle
https://hg.python.org/cpython/rev/c3c47ea32f72
--
nosy: +python-dev
___
STINNER Victor added the comment:
I commited both patches. Thanks Antoine for the review of
py_read_write-2.patch, I removed the commented assertion.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset e232b57ee784 by Victor Stinner in branch 'default':
Issue #23708: select.devpoll now retries its internal write() when interrupted
https://hg.python.org/cpython/rev/e232b57ee784
--
___
Python tracker
STINNER Victor added the comment:
With py_read_write.patch in debug mode, test_threading crash with an assertion
error because of the issue #15751. Currently, it's not possible to call
assert(PyGILState_Check()); inside Py_NewInterpreter(), while creating a
subinterpreter (ex:
New submission from STINNER Victor:
To factorize code handling EINTR, I propose add 2 new functions to fileutils.h:
_Py_read() and _Py_write().
Attached patch adds these functions and use them in the os and _io modules.
The code of the functions is based on the code from the os and _io
STINNER Victor added the comment:
select_write.patch: use _Py_write() in the select module.
--
Added file: http://bugs.python.org/file38558/select_write.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23708
STINNER Victor added the comment:
I created the issue #23709 for the ossaudiodev module: Refactor ossaudiodev:
use _Py_read and _Py_write with the Py_buffer.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23708
STINNER Victor added the comment:
Oops, there was a bug in FileIO.readall(), fixed in the new patch
py_read_write-2.patch.
I also commented assert(PyGILState_Check()); to workaround the issue #15751.
--
Added file: http://bugs.python.org/file38562/py_read_write-2.patch
14 matches
Mail list logo
