[issue23921] Standardize documentation whitespace, formatting

Serhiy Storchaka added the comment: Addressed Martin's Georg's and my comments, resolved conflicts, stripped trailing spaces, backported to 2.7. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7

[issue23921] Standardize documentation whitespace, formatting

Roundup Robot added the comment: New changeset be85897e6d58 by Serhiy Storchaka in branch '2.7': Issue #23921: Standardized documentation whitespace formatting. https://hg.python.org/cpython/rev/be85897e6d58 -- ___ Python tracker

[issue23921] Standardize documentation whitespace, formatting

Roundup Robot added the comment: New changeset 2b492ea961c1 by Serhiy Storchaka in branch '3.5': Issue #23921: Standardized documentation whitespace formatting. https://hg.python.org/cpython/rev/2b492ea961c1 New changeset 909099686e6e by Serhiy Storchaka in branch 'default': Issue #23921:

[issue23921] Standardize documentation whitespace, formatting

Changes by Serhiy Storchaka : -- assignee: docs@python -> serhiy.storchaka ___ Python tracker ___

[issue23921] Standardize documentation whitespace, formatting

Georg Brandl added the comment: I had no idea we had so many cases of wonky indentation :) This looks good to me, apart from a few comments I left on rietveld. -- ___ Python tracker

[issue23921] Standardize documentation whitespace, formatting

Serhiy Storchaka added the comment: James, could you please update your patch to address Martin's comments? In general the patch LGTM and I hope to commit it in short time. -- nosy: +georg.brandl versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue23921] Standardize documentation whitespace, formatting

Martin Panter added the comment: I do prefer extra space before a comment, otherwise it looks too much like some kind of “x # y” binary operator. So I think those changes are worthwhile. I left some review comments, mainly minor suggestions. Most of the other changes look worthwhile. Others I

[issue23921] Standardize documentation whitespace, formatting

Changes by R. David Murray : -- nosy: -r.david.murray ___ Python tracker ___ ___

[issue23921] Standardize documentation whitespace, formatting

Changes by R. David Murray : -- nosy: -r.david.murray ___ Python tracker ___ ___

[issue23921] Standardize documentation whitespace, formatting

R. David Murray added the comment: Sorry, I'm not going to have time to look at it. -- nosy: +r.david.murray ___ Python tracker ___

[issue23921] Standardize documentation whitespace, formatting

Serhiy Storchaka added the comment: The patch mostly LGTM. Most changes are trivial, but the patch also fixes few bugs. It is nice that the patch adds empty lines after blocks, this makes copying the code to interactive interpreter easier. I left comments on Rietveld. The most questionable

[issue23921] Standardize documentation whitespace, formatting

James Edwards added the comment: Attaching revised patch per reviews. Notable changes: * Reverted howto/curses.rst multiple inline statements - multi-target assignment (curses.rst is now unchanged) * Reverted library/subprocess.rst == to # == changes since there are other

[issue23921] Standardize documentation whitespace, formatting

James Edwards added the comment: Thanks for the review Serhiy. I'll prepare a revised patchset, given the comments from you and Berker and have it uploaded today. Thanks again. -- ___ Python tracker rep...@bugs.python.org

[issue23921] Standardize documentation whitespace, formatting

James Edwards added the comment: Thanks Berker, I responded to most of your comments in rietveld. A few of your comments suggested we should get rid of X, and while I can't say I disagree, I really tried to limit the scope of the changes to whitespace and formatting. As far as the script

[issue23921] Standardize documentation whitespace, formatting

Berker Peksag added the comment: Patch looks good to me. Thanks! :) I left a couple of comments on Rietveld: http://bugs.python.org/review/23921/ We can probably ignore the following type of changes too: - if pid == 0: # In a child process + if pid == 0: # In a child process -

[issue23921] Standardize documentation whitespace, formatting

R. David Murray added the comment: I will have comments on this, but it may be a bit before I get to it. In general I'm not sure of the value, though in the little bit I scanned so far there are at least a few changes that look worthwhile. -- ___

[issue23921] Standardize documentation whitespace, formatting

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +r.david.murray, serhiy.storchaka stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23921 ___

[issue23921] Standardize documentation whitespace, formatting

New submission from James Edwards: I realize this is a huge patch, I'd be happy to split it to multiple little patches (one per file, one per documentation directory, etc.) to make things easier. Just let me know. The patch attempts to do a few things (with exceptions, as noted below):

[issue23921] Standardize documentation whitespace, formatting

Changes by James Edwards jh...@jheiv.com: -- versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23921 ___ ___ Python-bugs-list