Jakub Kadlčík added the comment:
Hello, I think the example code snippets are awesome and no doubts, they helped
me a lot.
The only problem is that they are not idiomatic. They look like C more than
Python.
I suggest following patch
--
nosy: +FrostyX
Added file:
Ned Deily added the comment:
Jakub, thanks for your suggested changes. But this issue was closed and the
documentation updated many years ago. Please open a new issue with your
suggested changes, otherwise they will likely be forgotten and ignored.
--
nosy: +ned.deily
Georg Brandl [EMAIL PROTECTED] added the comment:
Committed patch in r61999. Thanks!
--
resolution: - accepted
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2406
__
Guilherme Polo [EMAIL PROTECTED] added the comment:
Hello,
(some comments)
What about using gzip.open instead of GzipFile ? It is just a shorthand,
but I prefer it (just my opinion). Also, remove those semicolons.
At the second example you called close on the string object, I guess you
M.-A. DARCHE [EMAIL PROTECTED] added the comment:
Thanks Guilherme (I hope Guilherme is your first name) for your very
constructive answer. I'll do exactly as you suggest.
Regards
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2406
M.-A. DARCHE [EMAIL PROTECTED] added the comment:
Here is the diff of the suggested modifications, which include Guilherme
remarks.
This is the kind of doc I would have like to read when I needed it.
Regards.
--
keywords: +patch
Added file:
Guilherme Polo [EMAIL PROTECTED] added the comment:
If I could I would commit it, but you have my support on this one
nevertheless ;)
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2406
__
New submission from M.-A. DARCHE [EMAIL PROTECTED]:
The documentation for the gzip python module as found at
http://docs.python.org/lib/module-gzip.html could be improved by code
examples. Those examples are really lacking.
Here below are the code snippets I propose. This is inspired by