[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: PR 25182 fixes the issue, so I am closing this again. Thanks for the quick fix, Irit! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: New changeset aadd4e10fda87b64ea527667238503da326a06e7 by Irit Katriel in branch 'master': bpo-24160: Fix test_pdb refleaks failure (GH-25182) https://github.com/python/cpython/commit/aadd4e10fda87b64ea527667238503da326a06e7 --

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Irit Katriel added the comment: With the patch: PS C:\Users\User\src\cpython-dev> ./python -m test test_pdb -R 3:3 Running Debug|x64 interpreter... 0:00:00 Run tests sequentially 0:00:00 [1/1] test_pdb beginning 6 repetitions 123456 .. == Tests result: SUCCESS == 1 test OK. Total

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Change by Irit Katriel : -- pull_requests: +23924 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/25182 ___ Python tracker ___

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Irit Katriel added the comment: Thanks, I'm looking. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: Per our buildbot policy (https://discuss.python.org/t/policy-to-revert-commits-on-buildbot-failure/404) we will need to revert this in 24 hours if is not fixed to avoid masking future errors. -- ___

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: Unfortunately PR21989 has breaking the refleaks buildbots. Example: https://buildbot.python.org/all/#/builders/320/builds/226/steps/5/logs/stdio To reproduce: ❯ ./python -m test test_pdb -R 3:3 0:00:00 load avg: 1.40 Run tests sequentially 0:00:00

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Irit Katriel added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Guido van Rossum added the comment: New changeset ad442a674ca443feec43a88a2d3671784712e550 by Irit Katriel in branch 'master': bpo-24160: Fix breakpoints persistence across multiple pdb sessions (GH-21989) https://github.com/python/cpython/commit/ad442a674ca443feec43a88a2d3671784712e550

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Tal Einat added the comment: Irit, I like the approach of your PR for an immediate fix, that we could consider backporting. In the long term, ISTM that we should refactor to store the breakpoints with only a single source of truth, and avoid the duplication between Breakpoint.bplist,

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Change by Georg Brandl : -- nosy: -georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Change by Irit Katriel : -- title: Pdb sometimes crashes when trying to remove a breakpoint defined in a different debugger sessoon -> Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session versions: +Python 3.10 -Python 2.7, Python