[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Changes by Terry J. Reedy : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Roundup Robot added the comment: New changeset 3c39413d277f by Terry Jan Reedy in branch '2.7': Issue #24199: Add stacklevel to deprecation warning call. https://hg.python.org/cpython/rev/3c39413d277f New changeset 048fce602bcd by Terry Jan Reedy in branch '3.4': Issue #24199: Add stacklevel to

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Terry J. Reedy added the comment: I get it now: the last line should be 'import idlelib.idlever' instead of the redundant line from idlever itself. Will change, and thanks for correcting this before I so the same in multiple other modules. -- ___

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Arfrever Frehtes Taifersar Arahesis added the comment: > Since I am not wrapping the warning, the default stacklevel seems to work on > all versions. The purpose of stacklevel=2 here would be to make warning message indicate which file contains import of deprecated module. See below example,

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Roundup Robot added the comment: New changeset 55b62e2c59f8 by Terry Jan Reedy in branch '2.7': Issue 24199: Deprecate idlelib.idlever with a warning on import. https://hg.python.org/cpython/rev/55b62e2c59f8 New changeset c51514826126 by Terry Jan Reedy in branch '3.4': Issue 24199: Deprecate

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Terry J. Reedy added the comment: Thanks, Brett. Since I am not wrapping the warning, the default stacklevel seems to work on all versions. Still to do: 1. Something in the docs (all branches), but with an eye toward other deprecations coming later. 2. Actually remove file in 3.6 branch, but

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Terry J. Reedy added the comment: Re-opening because there is still the issue of adding a deprecation warning on import. Brett, can you either point me toward or post here the code you are planning to use for other stdlib modules? -- nosy: +brett.cannon resolution: fixed -> stage:

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Brett Cannon added the comment: Typically it's warnings.warn(message, DeprecationWarning, stacklevel=2), but that stack level is wrong for Python 3.3 - 3.4 (fixed in 3.5.0). If this is purely for Python 3.6 I might be adding a nicer API for module deprecations, but if this is for other

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Roundup Robot added the comment: New changeset 117af4bc0513 by Benjamin Peterson in branch '2.7': make idlever.py self-updating (closes #24199) https://hg.python.org/cpython/rev/117af4bc0513 -- resolution: - fixed stage: needs patch - resolved status: open - closed

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Terry J. Reedy added the comment: To answer my question, I checked test___all__.py. The check_all helper has this: with support.check_warnings( (.* (module|package), DeprecationWarning), (, ResourceWarning), quiet=True): I presume this means that

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Roundup Robot added the comment: New changeset c473ac171041 by Terry Jan Reedy in branch '2.7': Issue #24199: Stop using idelver in aboutdialog. https://hg.python.org/cpython/rev/c473ac171041 New changeset c862166060ed by Terry Jan Reedy in branch '3.4': Issue #24199: Make idlever module self

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Terry J. Reedy added the comment: Benjamim, I made idlever update from sys.version until removed, so remove it from release process. Serhiy, yes there are extensions which might possibly use this private api, even if they really should not. I want to bring Nick (PEP 434 approver) into the

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Serhiy Storchaka added the comment: Are there third-party IDLE plugins? If yes, this change can break them. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24199 ___

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

New submission from Terry J. Reedy: Once upon a time, Idle was versioned separately from Python, though updated in lockstep with Python (#1515164, Martin's comment). The version was kept in idlever.py, with one line IDLE_VERSION = m.n.p Several years ago, the separate versioning was dropped

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Benjamin Peterson added the comment: That's fine. Just delete idlever.py, and I'll deal with it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24199 ___