[issue24745] Better default font for editor

Terry J. Reedy added the comment: This change caused a regression on Linux with 8.6.4 because TkFixedFont ends up with size = 0. Cannot open configuration file. See #26673. -- ___ Python tracker

[issue24745] Better default font for editor

Terry J. Reedy added the comment: The change from "Courier" to "TkDefaultFont" causes Options => Configure IDLE to fail at least on Arch Linux (#26673) and Fedora 23 (also #24951). The reason is still obscure to me. I will leave this closed, close #24951 as duplicate, and patch on #26673

[issue24745] Better default font for editor

Larry Hastings added the comment: Anything happening with this? We tag 3.5.0rc3 in about 36 hours. -- ___ Python tracker ___

[issue24745] Better default font for editor

Roundup Robot added the comment: New changeset 34a8078f6249 by Terry Jan Reedy in branch '2.7': Issue #24745: Prevent IDLE initialization crash with Tk 8.4; patch by Ned Deily. https://hg.python.org/cpython/rev/34a8078f6249 New changeset b4830b9f8c10 by Terry Jan Reedy in branch '3.4': Issue

[issue24745] Better default font for editor

Terry J. Reedy added the comment: I backported change already in 3.5.0+. -- priority: deferred blocker -> normal resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue24745] Better default font for editor

Terry J. Reedy added the comment: I just returned from a trip. I think restoring the status quo is sufficient, so I will likely apply to 2.7 and 3.4 and null merge forward. Is there anyway to get test run with 8.4 automatically, as least intermittantly, before the rc? --

[issue24745] Better default font for editor

Ned Deily added the comment: Unfortunately, we didn't test this change with Tk 8.4: TkFixedFont does not exist in 8.4. This means that, unless the user has already modified the IDLE configuration to use an explicit font, IDLE linked with Tk 8.4 crashes in initialization. $ mv .idlerc/

[issue24745] Better default font for editor

Larry Hastings added the comment: We're retagging 3.5.0rc1 to fix this and one other regression. Can someone step up and get this fix checked in in the next six or eight hours? You can just check in to the 3.5 branch on hg.python.org/cpython like normal (you won't have to use Bitbucket and

[issue24745] Better default font for editor

Changes by Ned Deily n...@acm.org: -- Removed message: http://bugs.python.org/msg248332 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24745 ___

[issue24745] Better default font for editor

Ned Deily added the comment: Unfortunately, we didn't test this change with Tk 8.4: TkFixedFont does not exist in 8.4. This means that, unless the user has already modified the IDLE configuration to use an explicit font, IDLE linked with Tk 8.4 crashes in initialization. $ mv .idlerc/

[issue24745] Better default font for editor

Roundup Robot added the comment: New changeset e39c4373b83f by Ned Deily in branch '3.5': Issue #24745: Prevent IDLE initialization crash with Tk 8.4: https://hg.python.org/cpython/rev/e39c4373b83f New changeset 8c55fb5a11d8 by Ned Deily in branch 'default': Issue #24745: merge from 3.5

[issue24745] Better default font for editor

Ned Deily added the comment: At Larry's request so that we can get 3.5.0rc1 out the door, I've checked in a temporary fix for 3.5 (and for 3.6) that should prevent the IDLE crash when linked with Tk 8.4. I'll leave the issue open for Terry to review and provide the final fix for all

[issue24745] Better default font for editor

Roundup Robot added the comment: New changeset 82198ae039cd by Terry Jan Reedy in branch '3.4': Issue 24745: Add ACKS entry. https://hg.python.org/cpython/rev/82198ae039cd New changeset bf14b74d6fc0 by Terry Jan Reedy in branch '3.5': Issue 24745: Add ACKS entry.

[issue24745] Better default font for editor

Terry J. Reedy added the comment: Review published with the changes I made, tested, and committed. I am not convinced that writing all 3 font attributes is needed, which is good since existing user files do not have all 3. But safer for future. Part of my preference to avoid user file when

[issue24745] Better default font for editor

Roundup Robot added the comment: New changeset 55e5f7766d2c by Terry Jan Reedy in branch '2.7': Issue 24745: Switch from Courier to platform-sensitive TkFixedFont as default https://hg.python.org/cpython/rev/55e5f7766d2c New changeset 5c992189414f by Terry Jan Reedy in branch '3.4': Issue

[issue24745] Better default font for editor

Mark Roseman added the comment: I've attached defaultfont.patch which will look for the magic value 'TkFixedFont' in the configuration file and do some appropriate magic with it. Most of the font handling smarts are now in a 'GetFont' call in configHandler, which as a bonus reduces some of

[issue24745] Better default font for editor

Mark Roseman added the comment: I'm ok with putting TkFixedFont in the config file. Only potential downside I see is that the code will look for this specific value, but people may read the config file and assume it could be changed to any Tk*Font. I'd strongly argue against putting in a

[issue24745] Better default font for editor

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24745 ___ ___ Python-bugs-list

[issue24745] Better default font for editor

Terry J. Reedy added the comment: For the benefit of anyone reading the file, I would prefer font = TkFixedFont, though I notice that LoadFontConfig has a backup default. Just as important, I think: IDLE Preferences = Font/Tabs = Editor Base Font needs a [Default] button so people can

[issue24745] Better default font for editor

Mark Roseman added the comment: Quick question how best to represent this in the config-main.def file. My thought is to leave a font= line there so that the GetOption call returns an empty string. The editor code can then detect that and substitute TkFixedFont. Would this break anything

[issue24745] Better default font for editor

Terry J. Reedy added the comment: In your online tutorial, your recommend root.option_add('*tearOff', FALSE) Why not here, and be covered everywhere, and in the future? Or is this needed for each Toplevel? -- ___ Python tracker

[issue24745] Better default font for editor

New submission from Mark Roseman: By default, IDLE chooses courier for the text editor font. As you'll see from the attached screenshot, while this looks ok on Windows, it's inconsistent with the standard fixed width fonts on Linux and OS X, and borders on unreadable particularly on the

[issue24745] Better default font for editor

Terry J. Reedy added the comment: I agree that Courier is ugly and a bad thing to hardcode. I long ago switched to Lucida Console, which other than i and l is very close to the Mac/linux examples. I had forgotten that Courier was the default. Ned, am I correct in thinking you would like

[issue24745] Better default font for editor

Ned Deily added the comment: With current ActiveTcl 8.5.18 on OS X, TkFixedFont translates to Monaco 11 point which looks fine on my laptop. I don't have a Retina display handy to see how it looks there but it's probably an improvement over Courier so changing the default sounds good to me.