Larry Hastings added the comment:
That's correct, it's just in 3.5.0 at the moment.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
___
Nick Coghlan added the comment:
Thanks Larry! Sorry I didn't get to this as soon as I got back from the US.
Will you add it to 3.5.1 and 3.6.0, or would you prefer I take care of that?
--
___
Python tracker rep...@bugs.python.org
Jeffrey Armstrong added the comment:
I pulled the 3.5 branch a few minutes ago, and the patch isn't present. Has it
not been pushed to hg.python.org?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
Larry Hastings added the comment:
Yes, I'll accept this into 3.5.0, please send a pull request.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
Larry Hastings added the comment:
I wanted to get this in to Python 3.5.0rc2, so I checked it in myself. Petr, I
gave you credit in the checkin comment and Misc/NEWS. Hope that's okay!
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: +Python 3.6
Brett Cannon added the comment:
It's ultimately Larry's call, but I think it should go into 3.5.0.
--
assignee: - larry
priority: deferred blocker - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
Robert Collins added the comment:
Patch looks good to me too. I think this needs to be put forward as a PR to
bitbucket right? It looks Release Critical to me.
--
nosy: +rbcollins
___
Python tracker rep...@bugs.python.org
Changes by Mikhail Terekhov ter...@gmail.com:
--
nosy: +termim
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
___
Python-bugs-list
Larry Hastings added the comment:
Uh, Nick? You didn't add me to this bug.
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
Eric Snow added the comment:
Looks fine to me. Nick had suggested calling exec_builtin from exec_dynamic
(to the same effect as your patch), but I don't consider that much of an issue.
:)
--
stage: - commit review
___
Python tracker
Petr Viktorin added the comment:
Right. I think a common helper is cleaner than calling a clinic-generated
wrapper.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
Petr Viktorin added the comment:
Apologies for the delay; I was on vacation.
This was indeed a mistake in PEP 489 implementation. I agree with Nick on the
solution.
Here is a patch that adds exec_builtin, with implementation shared with
exec_dynamic.
--
keywords: +patch
Added file:
Nick Coghlan added the comment:
This is an interesting find - thanks.
Adding Larry as 3.5 release manager to the cc here, as I think the right fix
actually involves an API adjustment inside _imp.
One of the consequences of PEP 489 (multi-phase initialisation) was that
builtin imports and
Changes by Ned Deily n...@acm.org:
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
___
Changes by Brett Cannon br...@python.org:
--
priority: normal - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24769
___
___
New submission from Jeffrey Armstrong:
When attempting to build Python without dynamic loading (HAVE_DYNAMIC_LOADING
is not defined), the module _imp will not have the function exec_dynamic.
However, Lib/bootstrap.py seems to assume that _imp.exec_dynamic exists,
causing the error:
16 matches
Mail list logo