Roundup Robot added the comment:
New changeset d9e0c82d8653 by Robert Collins in branch '3.4':
Issue #24774: Fix docstring in http.server.test.
https://hg.python.org/cpython/rev/d9e0c82d8653
New changeset 845c79097c21 by Robert Collins in branch '3.5':
Issue #24774: Fix docstring in
Robert Collins added the comment:
Thanks for the patch. Applied to 3.4 and up.
--
nosy: +rbcollins
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24774
Martin Panter added the comment:
Yeah you are probably right. This way keeps things simple.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24774
___
Chiu-Hsiang Hsu added the comment:
I'm not quite sure we should put argument parsing back into the test() function
or just fix docstring. It already expose port and bind through function
arguments. It looks wierd to me to have function arguments CLI arguments
modifying the same variable in
New submission from 許邱翔:
In http.server.test, it still say This runs an HTTP server on port 8000 (or
the first command line argument)., but it won't read command line argument any
more.
since this commit (https://hg.python.org/cpython/rev/935a656359ae)
--
components: Library (Lib)
Martin Panter added the comment:
Patch looks okay to me, although another option could be to move the argument
parsing back into the test() function, where it was originally.
BTW I don’t think the 3.3 branch is open to fixes like this any more.
--
nosy: +vadmium
stage: - patch review
