[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True

Changes by Eric V. Smith : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True

Roundup Robot added the comment: New changeset 5230115de64d by Eric V. Smith in branch 'default': Issue #24779: Remove unused rawmode parameter to unicode_decode. https://hg.python.org/cpython/rev/5230115de64d -- nosy: +python-dev ___ Python tracker

[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True

Changes by Brett Cannon : -- assignee: -> eric.smith ___ Python tracker ___ ___

[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True

New submission from Eric V. Smith: The only call to decode_unicode is this: if (!*bytesmode !rawmode) { return decode_unicode(c, s, len, rawmode, c-c_encoding); } So rawmode will always be 0. Removing this will delete a call to PyUnicode_DecodeRawUnicodeEscape in decode_unicode.

[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True

Eric V. Smith added the comment: That's poor wording on my part: the call to PyUnicode_DecodeRawUnicodeEscape isn't actually execute if rawmode is false. So it's really just a dead branch that's being deleted. -- ___ Python tracker

[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True

Brett Cannon added the comment: Then I say delete it. -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24779 ___ ___