[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: oops. yeah, I got my terminology wrong. It accepts only a byte-string. -- ___ Python tracker ___

[issue24984] document AF_BLUETOOTH socket address formats

Roundup Robot added the comment: New changeset 00db99149cdd by Martin Panter in branch '3.4': Issue #24984: BTPROTO_SCO supports only bytes objects https://hg.python.org/cpython/rev/00db99149cdd New changeset b507a7e79154 by Martin Panter in branch '3.5': Issue #24984: Merge BTPROTO_SCO doc

[issue24984] document AF_BLUETOOTH socket address formats

Changes by Martin Panter : -- status: open -> closed ___ Python tracker ___ ___

[issue24984] document AF_BLUETOOTH socket address formats

Changes by Martin Panter : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue24984] document AF_BLUETOOTH socket address formats

Roundup Robot added the comment: New changeset da9b26670e44 by Martin Panter in branch '3.4': Issue #24984: Document AF_BLUETOOTH socket address formats https://hg.python.org/cpython/rev/da9b26670e44 New changeset 4ce8450da22d by Martin Panter in branch '3.5': Issue #24984: Merge 3.4 into 3.5

[issue24984] document AF_BLUETOOTH socket address formats

Berker Peksag added the comment: Thanks for the patch, Tim. I think we can also create separate issues for AF_PACKET and AF_CAN and mark them as "easy". -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I created #25041 to handle AF_PACKET. It seems AF_CAN is already in the docs, so the person making the change for AF_PACKET can just remove that mention of AF_CAN farther down. -- ___ Python tracker

[issue24984] document AF_BLUETOOTH socket address formats

Martin Panter added the comment: Hello again. The patch I committed says BTPROTO_SCO accepts a bytes-like object. However I suspect it is actually restricted to bytes only: >>> s = socket(AF_BLUETOOTH, SOCK_SEQPACKET, BTPROTO_SCO) >>> s.bind(bytearray(b"12:23:34:45:56:67")) Traceback (most

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: Martin, looks good. Thanks for pointing out how to properly tag the version change, and thanks for adding me to the ACKS file. -- ___ Python tracker

[issue24984] document AF_BLUETOOTH socket address formats

Martin Panter added the comment: Here is a suggestion of how to add a versionchanged tag. Let me know if it is accurate or not. (I’m not actually familiar with the history.) -- Added file: http://bugs.python.org/file40370/bluetooth_socket_docs_5.patch

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I'm not really sure how to add a `versionadded` tag to specify that only the BSD-specific support was added in 3.2 (as general support was there prior to that). If I just add the plain tag below that bullet point it would imply that the whole protocol was added

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I added a note to BTPROTO_SCO that it doesn't work in FreeBSD (I forgot to mention that). -- Added file: http://bugs.python.org/file40341/bluetooth_socket_docs_3.patch ___ Python tracker

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: I'm not sure the proper way to update the patch... I can't seem to edit the existing one or replace it. I'm uploading an updated one, but should I simply "unlink" (aka delete) the old one? -- Added file:

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: Martin, the odd thing with the SCO protocol is it's expecting an bluetooth address as a byte string (ex b'12:23:34:45:56:67' [note the `b`]) where the other 3 are expecting a regular string (ex '12:23:34:45:56:67'). I think it may have been a case of someone

[issue24984] document AF_BLUETOOTH socket address formats

Tim Tisdall added the comment: changed "This protocol does not work under FreeBSD." to the more accurate "This protocol is not supported under FreeBSD." -- Added file: http://bugs.python.org/file40343/bluetooth_socket_docs_4.patch ___ Python tracker

[issue24984] document AF_BLUETOOTH socket address formats

New submission from Tim Tisdall: Currently https://docs.python.org/3.6/library/socket.html#socket-families only says "Certain other address families (AF_BLUETOOTH, AF_PACKET, AF_CAN) support specific representations." and there's a comment in the docs saying "document them!"... So, I'm

[issue24984] document AF_BLUETOOTH socket address formats

Martin Panter added the comment: Thanks for the patch and the archeological research. I made some minor grammar nitpicks in the code review. Documentation typically gets applied to all the open branches. In this case 3.4–3.6 should be applicable. Maybe 2.7 also if you are interested; it may