[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: The test doesn't fail anymore on buildbots. I ran manually test_strptime with a memory limit of 1 GB on Python 3.5 and 3.6: the test pass. Can we close the issue? -- ___ Python tracker

[issue25029] MemoryError in test_strptime

Steve Dower added the comment: Done. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25029] MemoryError in test_strptime

Roundup Robot added the comment: New changeset bd7aed300a1b by Steve Dower in branch '3.5': Issue #25029: MemoryError in test_strptime https://hg.python.org/cpython/rev/bd7aed300a1b New changeset 706b9eaba734 by Steve Dower in branch '3.5': Merge fix for #25029

[issue25029] MemoryError in test_strptime

New submission from Serhiy Storchaka: All builds on edelsohn-fedora-ppc64 are red starting from build 55 for 3.x and build 41 for 3.5. 3.4 is green. http://buildbot.python.org/all/builders/PPC64%20Fedora%203.x/builds/55/ http://buildbot.python.org/all/builders/PPC64%20Fedora%203.5/builds/41/

[issue25029] MemoryError in test_strptime

Larry Hastings added the comment: Any clue here? Is this unaligned access? -- ___ Python tracker ___ ___

[issue25029] MemoryError in test_strptime

David Edelsohn added the comment: PPC64 is not a strict alignment system. The system is running a non-recent release of Fedora, so it could be a bad interaction with libc. -- ___ Python tracker

[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: It's a regression introduced by c31dad22c80d (Issue #24917). -- nosy: +steve.dower ___ Python tracker ___

[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: Script to reproduce the issue: --- import time import locale import pprint time_tuple = time.struct_time((1999,3,17,1,44,55,2,76,0)) p1 = time.strftime("%p", time_tuple) print("current LC_TIME", repr(p1)) locale.setlocale(locale.LC_TIME, ('de_DE', 'UTF8')) p2

[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: Again, this issue remembers me the idea of rewriting strftime() in Python. We already have _strptime.py. -- ___ Python tracker

[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: Oh wait, the VmPeak is *much* high when running test_strptime: * test_os VmPeak: 380 992 kB * test_strptime VmPeak: 8 608 972 kB (8 GB!?) 1 GB should be enough for everybody: $ bash -c 'ulimit -v 100; ./python -m test -v test_strptime' ..

[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: I ran test_strptime & test_os with tracemalloc: test_os memory peak is higher than test_strptime memory peak (I ran the two tests independently). So the bug cannot be reproduce on my Fedora 22 (x86_64). -- nosy: +haypo

[issue25029] MemoryError in test_strptime

Steve Dower added the comment: Thanks. I'll submit a PR for 3.5.0 later tonight - can't seem to clone Larry's repo successfully at work for some reason. -- ___ Python tracker

[issue25029] MemoryError in test_strptime

eryksun added the comment: Steve, it seems to me that for MSVC the EINVAL test should come first: _Py_BEGIN_SUPPRESS_IPH olderr = errno; errno = 0; buflen = format_time(outbuf, i, fmt, ); err = errno; errno = olderr; _Py_END_SUPPRESS_IPH if (buflen == 0

[issue25029] MemoryError in test_strptime

Steve Dower added the comment: @eryksun - that's exactly what I've just done :) Unfortunately, I don't have a _locale module, so I can't do Victor's test. Attached my patch in case Victor is around to test it. -- keywords: +patch Added file:

[issue25029] MemoryError in test_strptime

STINNER Victor added the comment: My test runs the following command on Linux (Fedora 22): make && bash -c 'ulimit -v 100; ./python -u -m test -v test_strptime' * current default branch (rev 3c0c153d6b02): MemoryError * with 25029_1.patch: the test pass --

[issue25029] MemoryError in test_strptime

Steve Dower added the comment: Sorry Larry. I'll fix it. -- assignee: -> steve.dower priority: normal -> release blocker ___ Python tracker ___

[issue25029] MemoryError in test_strptime

Steve Dower added the comment: PR at https://bitbucket.org/larry/cpython350/pull-requests/21/issue-25029-memoryerror-in-test_strptime/diff -- ___ Python tracker

[issue25029] MemoryError in test_strptime

Steve Dower added the comment: Probably should, since the fix that caused it was in for rc3. There's no section for 3.5.0 final yet though (that's my excuse, anyway :) ) -- ___ Python tracker

[issue25029] MemoryError in test_strptime

Larry Hastings added the comment: Does this need a Misc/NEWS entry? -- ___ Python tracker ___ ___

[issue25029] MemoryError in test_strptime

Alexander Belopolsky added the comment: I would blame this change: . The rest should not have any effect on Linux. -- nosy: +belopolsky ___ Python tracker