[issue25038] test_os.TestSendfile.test_keywords() introduced a regression

Changes by Martin Panter : -- components: +Tests resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue25038] test_os.TestSendfile.test_keywords() introduced a regression

Martin Panter added the comment: Victor, the BSD and OS X buildbots seem to be passing test_os now. E.g.: http://buildbot.python.org/all/buildslaves/koobs-freebsd10 http://buildbot.python.org/all/buildslaves/intel-yosemite-icc Do you agree we can close this? -- nosy: +berker.peksag

[issue25038] test_os.TestSendfile.test_keywords() introduced a regression

STINNER Victor added the comment: Sure, close the issue if the regression is fixed. -- ___ Python tracker ___

[issue25038] test_os.TestSendfile.test_keywords() introduced a regression

New submission from STINNER Victor: The change e42e2bd47168 introduced a regression, test_os started to fail on FreeBSD. What is the rationale of the change? For example, test_os pass in the previous build on the same buildbot. I don't know if it makes sense to pass None to headers and/or

[issue25038] test_os.TestSendfile.test_keywords() introduced a regression

Martin Panter added the comment: I believe revision e42e2bd47168 is actually the cure, and test failure is actually caused by a new test I added in revision fdb5d84f9948. So hopefully things are fixed now, but I will keep an eye on the buildbots. In fdb5d84f9948, I originally added the