[issue25043] document socket constants for Bluetooth

Martin Panter added the comment: Thanks for your work on this. I think the patch is good, although I might add :const:`BDADDR_ANY` etc markup around the references within the text. By the way, you don’t normally need to make separate patches for each branch. When I commit this I will just

[issue25043] document socket constants for Bluetooth

Roundup Robot added the comment: New changeset 152568976062 by Martin Panter in branch '3.4': Issue #25043: Document BDADDR_ and HCI_ Bluetooth socket constants https://hg.python.org/cpython/rev/152568976062 New changeset 3f475417eadd by Martin Panter in branch '3.5': Issue #25043: Merge

[issue25043] document socket constants for Bluetooth

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue25043] document socket constants for Bluetooth

Tim Tisdall added the comment: Okay, since there's currently no existing tests for the Bluetooth components of socket and the only example for BDADDR_ALL seems to be for something I'm not sure you can do in socket, I'm just going to not bother including it. I've attached a 3.6 patch without

[issue25043] document socket constants for Bluetooth

Tim Tisdall added the comment: okay, I talked to one of the Bluez developers and he recommended leaving out BDADDR_ALL since it doesn't seem to correspond to anything in the kernel. -- ___ Python tracker

[issue25043] document socket constants for Bluetooth

Changes by Tim Tisdall : Added file: http://bugs.python.org/file40426/bdaddr_35_1.patch ___ Python tracker ___

[issue25043] document socket constants for Bluetooth

Changes by Tim Tisdall : -- keywords: +patch Added file: http://bugs.python.org/file40424/bdaddr_36_1.patch ___ Python tracker ___

[issue25043] document socket constants for Bluetooth

Changes by Tim Tisdall : Added file: http://bugs.python.org/file40425/bdaddr_34_1.patch ___ Python tracker ___

[issue25043] document socket constants for Bluetooth

Tim Tisdall added the comment: I'm not sure how to unit test a constant... it's just a string. If you're asking for a unit test for when you'd actually make use of the constant, I haven't been able to figure out that situation yet. It seems like in Bluez 4.101 it's used to issue a command

[issue25043] document socket constants for Bluetooth

Martin Panter added the comment: Well if the constant is not very useful then maybe we shouldn’t add it :) For testing, nothing complicated. Maybe check the module attributes exist, and are strings. In the past, people have converted module-level constants to enums, and introduced a typo in a

[issue25043] document socket constants for Bluetooth

New submission from Tim Tisdall: further to #24984, I noticed there are constants that aren't mentioned in the docs. Also BDADDR_ALL is missing (which is defined in Bluez's bluetooth.h) so I added it. Now, I'm not totally clear on supplying multi-version patches... I know 3.5 is in

[issue25043] document socket constants for Bluetooth

Martin Panter added the comment: The new constant would probably have to go into 3.6 only. I suggest make two patches: your documentation patch to be applied to 3.4+, and the new constant, against 3.6 only. Also, it would be good to get a unit test for the new constant. -- nosy: