[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Roundup Robot added the comment: New changeset 52ff0c00a404 by Serhiy Storchaka in branch '3.5': Issue #25462: The hash of the key now is calculated only once in most https://hg.python.org/cpython/rev/52ff0c00a404 New changeset 828c9b920532 by Serhiy Storchaka in branch 'default': Issue #25462:

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Changes by Serhiy Storchaka : -- stage: commit review -> resolved ___ Python tracker ___

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Serhiy Storchaka added the comment: Thank you Raymond and Eric. -- ___ Python tracker ___ ___

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Raymond Hettinger added the comment: The patch looks correct, and it improves the integrity of the C implementation. -- ___ Python tracker ___

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Serhiy Storchaka added the comment: Could you please make a review of this patch Eric? It is moved to separate issue because it is enough large and complex. -- ___ Python tracker

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file40960/odict_knownhash_2.patch ___ Python tracker ___

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

New submission from Serhiy Storchaka: There are private _PyDict_*_KnownHash functions that allow to avoid repeated hash calculation in complex operations with a dict. Proposed patch makes C implementation of OrderedDict to use these functions. It is not just an optimization, it makes some