[issue25558] Use static asserts in C code

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue25558] Use static asserts in C code

STINNER Victor added the comment: This issue can now be closed, no? (I don't think that it's worth to add a new macro and make the existing macro more strict.) -- ___ Python tracker

[issue25558] Use static asserts in C code

Roundup Robot added the comment: New changeset 45a404d33c2d by Serhiy Storchaka in branch 'default': Issue #25558: Use compile-time asserts. https://hg.python.org/cpython/rev/45a404d33c2d -- ___ Python tracker

[issue25558] Use static asserts in C code

Serhiy Storchaka added the comment: > By the way, I don't know what happens if you pass a variable to > Py_BUILD_ASSERT_EXPR() rather than a constant. If the compiler can't calculate it at compile time (e.g. int_var <= INT_MAX), your are out of luck. > Maybe we could use

[issue25558] Use static asserts in C code

Roundup Robot added the comment: New changeset ad44d551c13c by Serhiy Storchaka in branch '3.5': Issue #25558: Refactoring OrderedDict iteration. https://hg.python.org/cpython/rev/ad44d551c13c New changeset 51f3547da99c by Serhiy Storchaka in branch 'default': Issue #25558: Refactoring

[issue25558] Use static asserts in C code

Serhiy Storchaka added the comment: Wrong issue. The correct one is issue24726. -- ___ Python tracker ___ ___

[issue25558] Use static asserts in C code

Serhiy Storchaka added the comment: Oh, no, the correct one is issue25410. -- ___ Python tracker ___ ___

[issue25558] Use static asserts in C code

STINNER Victor added the comment: use_Py_BUILD_ASSERT_EXPR.patch looks good to me. But you should revert the change on decimal, as asked by Stefan, and I suggested to move an assertion inside the related function (see my comment on Rietveld). """ A library can follow the example in the

[issue25558] Use static asserts in C code

New submission from Serhiy Storchaka: Proposed patch converts some dynamic assert to static asserts (Py_BUILD_ASSERT_EXPR). This allows to check static invariants at compile time. -- components: Extension Modules, Interpreter Core files: use_Py_BUILD_ASSERT_EXPR.patch keywords: patch

[issue25558] Use static asserts in C code

Serhiy Storchaka added the comment: OK, I'll exclude Modules/_decimal/_decimal.c. -- ___ Python tracker ___

[issue25558] Use static asserts in C code

Stefan Krah added the comment: Thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue25558] Use static asserts in C code

STINNER Victor added the comment: > This is a public name and can be used in third-party code. Do you mean that a library can really rely on the result!? It would be insane :-) -- ___ Python tracker

[issue25558] Use static asserts in C code

Serhiy Storchaka added the comment: A library can follow the example in the comment. #define foo_to_char(foo) \ ((char *)(foo)\ + Py_BUILD_ASSERT_EXPR(offsetof(struct foo, string) == 0)) -- ___ Python tracker

[issue25558] Use static asserts in C code

STINNER Victor added the comment: +(void)Py_BUILD_ASSERT_EXPR(INT_MAX <= _PyTime_MAX / SEC_TO_NS); Hum, maybe the existing macro should be renamed to Py_BUILD_ASSERT_EXPR and a new Py_BUILD_ASSERT_EXPR macro should add the (void) to ignore the result? It would avoid to have to repeat

[issue25558] Use static asserts in C code

STINNER Victor added the comment: Hum, maybe I wasn't clear: I propose attached macro.patch. -- Added file: http://bugs.python.org/file40956/macro.patch ___ Python tracker

[issue25558] Use static asserts in C code

Serhiy Storchaka added the comment: This is a public name and can be used in third-party code. -- ___ Python tracker ___

[issue25558] Use static asserts in C code

Stefan Krah added the comment: Serhiy, could you please not change stuff that I maintain? I know you have the best intentions, but I really don't like these kinds of changes (just like you don't like trailing whitespace :). -- nosy: +skrah ___