[issue25591] refactor imaplib tests

Roundup Robot added the comment: New changeset a10d6ab65b23 by Victor Stinner in branch '3.5': Issue #25591: Fix test_imaplib if ssl miss https://hg.python.org/cpython/rev/a10d6ab65b23 -- ___ Python tracker

[issue25591] refactor imaplib tests

R. David Murray added the comment: Committed. FYI, I did have to make a few tweaks. There were several lines longer than 80 characters still that I wrapped. The tests failed with -W error:BytesWarning, something I normally run the tests with. That required a fix to the library (a decode

[issue25591] refactor imaplib tests

Roundup Robot added the comment: New changeset 75f9cca86fa1 by R David Murray in branch '3.5': #25591: improve imap tests. https://hg.python.org/cpython/rev/75f9cca86fa1 New changeset 4663466b0d66 by R David Murray in branch '3.6': Merge: #25591: improve imap tests.

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: Thank you David, of course I'll remind you :) -- ___ Python tracker ___ ___

[issue25591] refactor imaplib tests

Changes by R. David Murray : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue25591] refactor imaplib tests

R. David Murray added the comment: Revised patch LGTM. Once 3.6 is out the door I'll commit it, though you may need to remind me. -- stage: patch review -> commit review versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: David I apologize for 2 emails from Reitveld, for some reason it didn't show me all in one view :/ (I need to master Reitveld better). I've just updated patch according to your comments. -- Added file:

[issue25591] refactor imaplib tests

Changes by Maciej Szulik : -- hgrepos: -322 ___ Python tracker ___ ___ Python-bugs-list

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: Thanks, I'll try to update the patch in the following days. -- ___ Python tracker ___

[issue25591] refactor imaplib tests

R. David Murray added the comment: Reitveld can diff patchsets, so I used that for review. -- ___ Python tracker ___

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: David I'm uploading the patch with all the review comments addressed. The changes from just the review can be seen here: https://bitbucket.org/soltysh/cpython/commits/91708e0c6e7c5230bd69b1135b82ef47b6dc4d43?at=default (please ignore the changes to

[issue25591] refactor imaplib tests

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue25591] refactor imaplib tests

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41680/new_imap_tests_v3.diff ___ Python tracker ___

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: David I think I've re-implemented, using the new style, all the methods from ThreadedNetworkedTests and ThreadedNetworkedTestsSSL, the new classes are NewIMAPTests and NewIMAPSSLTests accordingly. -- stage: -> patch review Added file:

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: David can you please take a look once more, I've applied all the changes you've asked for. I'm currently working on adding the existing tests rewritten to use the new framework so it's easy to compare. It's still in progress but the general idea should

[issue25591] refactor imaplib tests

Maciej Szulik added the comment: I'm reopening this issue per discussion with David we've had on IRC. The scope of this issue to refactor current tests to make them more readable and clean. The most important work is: 1. having single _setup method 2. the _setup method should addClenup to