[issue25616] Extract OrderedDict tests into separate file

2015-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Raymond. Here is a patch. It is in Git format, hence Rietveld will not work with it. During creating a patch I found a bug in test_dict_update, it tested only default implementation and didn't test subclasses. -- keywords: +patch stage:

[issue25616] Extract OrderedDict tests into separate file

2015-11-15 Thread Raymond Hettinger
Raymond Hettinger added the comment: If it helps with all the great work you're doing, go ahead and move the OD tests out to a separate file. -- ___ Python tracker

[issue25616] Extract OrderedDict tests into separate file

2015-11-13 Thread Eric Snow
Eric Snow added the comment: FWIW, I totally support this. I originally had a patch up that did so but Raymond indicated that he'd rather not split the tests out though I made exactly the same arguments that you have. Perhaps he's changed his mind in the intervening years (or I

[issue25616] Extract OrderedDict tests into separate file

2015-11-13 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: OrderedDict tests now are about 1/3 of test_collections, and I think their volume will grow. I suggest to extract these tests into separate file test_ordereddict. There are precedences: test_deque (deque also is implemented in C), and test_userdict,