[issue26027] Support Path objects in the posix module

Roundup Robot added the comment: New changeset 9be0286772bf by Brett Cannon in branch 'default': Issue #26027, #27524: Document the support for path-like objects in os and os.path. https://hg.python.org/cpython/rev/9be0286772bf -- ___ Python tracker

[issue26027] Support Path objects in the posix module

Roundup Robot added the comment: New changeset d0d9d7f55cb5 by Brett Cannon in branch 'default': Issue #26027: Support path-like objects in PyUnicode-FSConverter(). https://hg.python.org/cpython/rev/d0d9d7f55cb5 -- ___ Python tracker

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Thanks for fixing it, Berker! On Sat, Aug 27, 2016, 12:59 Berker Peksag wrote: > > Berker Peksag added the comment: > > Builtbots look happy now: > > * Windows 7 SP1: >

[issue26027] Support Path objects in the posix module

Berker Peksag added the comment: Builtbots look happy now: * Windows 7 SP1: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/8177 * Windows 8: http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/2476 * Windows 10:

[issue26027] Support Path objects in the posix module

Eryk Sun added the comment: I wish the name was "pushCleanup" to emphasize that cleanup functions are popped and called in LIFO order. -- nosy: +eryksun ___ Python tracker

[issue26027] Support Path objects in the posix module

Berker Peksag added the comment: test_path_t_converter failure looks similar to http://bugs.python.org/issue27493#msg271047 (fixed by 5424252ce174.) I've tested a fix on my Windows box and the test passed for me. Hopefully 8ec5a00e5d75 will fix the problem on buildbots too :) --

[issue26027] Support Path objects in the posix module

Roundup Robot added the comment: New changeset 8ec5a00e5d75 by Berker Peksag in branch 'default': Issue #26027: Fix test_path_t_converter on Windows https://hg.python.org/cpython/rev/8ec5a00e5d75 -- ___ Python tracker

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: It's still failing: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/8176/steps/test/logs/stdio . Don't have time to look at why right now and I'm on a Mac ATM so I can't test locally to try and fix it until I'm at work on Monday. If

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Hopefully https://hg.python.org/cpython/rev/775158408ecb will fix the problem. -- status: open -> closed ___ Python tracker

[issue26027] Support Path objects in the posix module

Martin Panter added the comment: One more thing, ;) the Windows buildbots are failing to removing a temporary file: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/8173/steps/test/logs/stdio ==

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Thanks for catching that, Martin. I removed the test for bytearray as it was originally written before the deprecation. -- status: open -> closed ___ Python tracker

[issue26027] Support Path objects in the posix module

Roundup Robot added the comment: New changeset 32b93ba32aa0 by Brett Cannon in branch 'default': Issue #26027: Don't test for bytearray in path_t as that's now https://hg.python.org/cpython/rev/32b93ba32aa0 -- ___ Python tracker

[issue26027] Support Path objects in the posix module

Martin Panter added the comment: This change causes test_os to produce warnings, and can fail: $ hg update b64f83d6ff24 $ ./python -bWerror -m test -u all -W test_os [. . .] == ERROR: test_path_t_converter

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Thanks to Jelle for the initial commit and Serhiy for the code review! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26027] Support Path objects in the posix module

Roundup Robot added the comment: New changeset b64f83d6ff24 by Brett Cannon in branch 'default': Issue #26027, #27524: Add PEP 519/__fspath__() support to os and https://hg.python.org/cpython/rev/b64f83d6ff24 -- nosy: +python-dev ___ Python tracker

[issue26027] Support Path objects in the posix module

Changes by Brett Cannon : -- stage: test needed -> commit review ___ Python tracker ___ ___

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Here is a patch that incorporates Serhiy's feedback. -- Added file: http://bugs.python.org/file44159/path_converter.diff ___ Python tracker

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Thanks for the review! I'll probably update the patch next week based on your feedback (which I agree with). As for error messages and tests, they exist in my patches on issues dependent on this one (e.g. the tests included in issues #27524 and #27182 which

[issue26027] Support Path objects in the posix module

Serhiy Storchaka added the comment: Added comments on Rietveld. Needed tests for supporting path-like objects. And it would be nice to have few tests for error messages. -- assignee: serhiy.storchaka -> brett.cannon stage: commit review -> test needed

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Here is an updated patch that adds in change to posixmodule.c stemming from the new warning about using bytearrays. It also makes type checking more stringent for what __fspath__() returns. -- Added file:

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Here is a version of Jelle's patch but with PyOS_FSPath() inlined. Serhiy, does this work for you? -- stage: patch review -> commit review Added file: http://bugs.python.org/file44029/path_converter.diff ___ Python

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: I have no issues inlining -- with a comment about the inlining -- if it buys us better error messages in this critical case. -- ___ Python tracker

[issue26027] Support Path objects in the posix module

Serhiy Storchaka added the comment: At first glance issue27186-os_path_t.patch looks good. But with the patch applied the error message in case of incorrect argument type is always "expected str, bytes or os.PathLike object, not ...". Currently it is more detailed and specific: contains the

[issue26027] Support Path objects in the posix module

Serhiy Storchaka added the comment: I'll take a look. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26027] Support Path objects in the posix module

Brett Cannon added the comment: Did you still want to handle this, Serhiy, or should I assign the issue to myself? -- ___ Python tracker ___

[issue26027] Support Path objects in the posix module

Jelle Zijlstra added the comment: The patch is obsolete because PEP 519 ended up going with a different approach. I submitted a new patch for the path_t converter in issue27186. That patch probably fits better here, so I'm resubmitting it. -- nosy: +Jelle Zijlstra Added file:

[issue26027] Support Path objects in the posix module

Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___

[issue26027] Support Path objects in the posix module

Serhiy Storchaka added the comment: Here is preliminary patch without tests. Writing tests will be tiresome. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file42382/path_converter_path.patch ___ Python

[issue26027] Support Path objects in the posix module

Changes by Serhiy Storchaka : -- dependencies: +Clean up path_converter in posixmodule.c ___ Python tracker ___

[issue26027] Support Path objects in the posix module

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue26027] Support Path objects in the posix module

New submission from Serhiy Storchaka: path_converter should be changed to accept objects with the "path" attribute. See issue22570 for details. -- assignee: serhiy.storchaka components: Extension Modules messages: 257642 nosy: serhiy.storchaka priority: normal severity: normal stage: