[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Irit Katriel added the comment: > Irit, you just patched Temp file doc, can you look at the PR code? I don't consider myself and expert here, but I left a comment on PR29560 just to be a good sport. -- ___ Python tracker

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Terry J. Reedy added the comment: Also, which of the two patches. Irit, you just patched Temp file doc, can you look at the PR code? -- nosy: +iritkatriel ___ Python tracker

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Terry J. Reedy added the comment: Éric, you might use git log or git blame to see who that is active has patched the relevant file in the last few years. -- ___ Python tracker

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Éric Araujo added the comment: I believe the PR is in good shape. Can someone with expertise in tempfile review it? It would also be useful if the people who had a bug could test the new code. -- nosy: +eric.araujo, giampaolo.rodola versions: +Python 3.11 -Python 3.8

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Change by Adrian Garcia Badaracco : -- nosy: +adriangb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Change by Carey : -- nosy: +pR0Ps nosy_count: 6.0 -> 7.0 pull_requests: +27808 pull_request: https://github.com/python/cpython/pull/29560 ___ Python tracker ___

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Antti Haapala added the comment: ... to further clarify, it is disappointing that either BytesIO or TemporaryFile would work alone, but the one that merges these two doesn't. -- ___ Python tracker

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Antti Haapala added the comment: Another test case: import tempfile import io import json with tempfile.SpooledTemporaryFile(max_size=2**20) as f: tf = io.TextIOWrapper(f, encoding='utf-8') json.dump({}, fp=tf) I was writing json to a file-like object that I need to read in as

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Daniel Jewell added the comment: To add something additional here: The current documentation for tempfile.SpooledTemporaryFile indicates "This function operates exactly as TemporaryFile() does, except that data is spooled in memory until the file size exceeds max_size[...]" (see

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

nubirstein added the comment: My last comment meant to land somewhere else, but nonetheless it is related to this topic, so: SpooledTemporaryFile class from lib/tempfile.py still does not implement seekable() method. It could be like this (just two lines of code and my Flask.Request tests

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

nubirstein added the comment: Should I have been added my request there? Anyway I do suffer from lack of 'seekable()' implementation there -- nosy: +nubirstein ___ Python tracker

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Martin Panter added the comment: I was making suggestions, not demanding anything. Except for the quirk with __del__, Gary’s changes (revision fb28362) look okay to add on their own as a bug fix. I wouldn’t claim that IOBase is “fully implemented” however, until the return values for “seek”

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Terry J. Reedy added the comment: Martin, the PR has one 'approved' review, not from you. You appear to be requesting changes here, but it is not clear to me which are 'maybe' and which are 'must'. It is not obvious to me whether this should be treated as enhancement or behavior issue,

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Martin Panter added the comment: It may also be worth implementing BufferedIOBase and TextIOBase. (It seems buffering=0 isn’t reliable, e.g. rollover with limited disk space, so it may not be worth implementing RawIOBase.) To implement BufferedIOBase, “read1” and

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Changes by Roundup Robot : -- pull_requests: +3295 ___ Python tracker ___

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

New submission from Gary Fernie: SpooledTemporaryFile does not fully satisfy the abstract for IOBase. Namely, `seekable`, `readable`, and `writable` are missing. This was discovered when seeking a SpooledTemporaryFile-backed lzma file. You may quickly repro this:

[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

Martin Panter added the comment: It would be nice to add test cases for this. Looking at , there is a version changed notice for the truncate() method. So perhaps this should be added as a new feature