[issue26307] no PGO for built-in modules with `make profile-opt`

Gregory P. Smith added the comment: My change means that the build/ directory tree exists but won't have any files other than *.gc?? files in it after a make clean. I doubt this will bother anyone. That felt better for clean than just avoiding the removal of build/ entirely. --

[issue26307] no PGO for built-in modules with `make profile-opt`

Roundup Robot added the comment: New changeset 75dae0b2ccb3 by Gregory P. Smith in branch '2.7': Fixes issue26307: The profile-opt build now applys PGO to the built-in modules. https://hg.python.org/cpython/rev/75dae0b2ccb3 -- ___ Python tracker

[issue26307] no PGO for built-in modules with `make profile-opt`

Roundup Robot added the comment: New changeset 7d9cd4a0d488 by Gregory P. Smith in branch '3.5': Fixes issue26307: The profile-opt build now applys PGO to the built-in https://hg.python.org/cpython/rev/7d9cd4a0d488 New changeset bdc7292cf87e by Gregory P. Smith in branch 'default': Fixes

[issue26307] no PGO for built-in modules with `make profile-opt`

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___

[issue26307] no PGO for built-in modules with `make profile-opt`

Charalampos Stratakis added the comment: Pinging here. Christos could you test the patch? -- nosy: +cstratak ___ Python tracker ___

[issue26307] no PGO for built-in modules with `make profile-opt`

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file42000/pgofix-cpython3.patch ___ Python tracker ___

[issue26307] no PGO for built-in modules with `make profile-opt`

Alecsandru Patrascu added the comment: I've added the patch here also. -- keywords: +patch Added file: http://bugs.python.org/file41999/pgofix-cpython2.patch ___ Python tracker

[issue26307] no PGO for built-in modules with `make profile-opt`

Changes by Brett Cannon : -- stage: -> needs patch ___ Python tracker ___ ___

[issue26307] no PGO for built-in modules with `make profile-opt`

Alecsandru Patrascu added the comment: I've added a fix for the PGO builds after the issue pointed out by you. Can you please test it also? -- ___ Python tracker

[issue26307] no PGO for built-in modules with `make profile-opt`

Alecsandru Patrascu added the comment: Thank you for noticing and signaling this issue. Since I proposed the PGO patches, I will fix it in another patch, as I don't want it to break any builds. -- ___ Python tracker

[issue26307] no PGO for built-in modules with `make profile-opt`

Changes by Alecsandru Patrascu : -- nosy: +alecsandru.patrascu ___ Python tracker ___