subject:"\[issue26348\] activate.fish sets VENV prompt incorrectly"

[issue26348] activate.fish sets VENV prompt incorrectly

2016-06-30 Thread Vinay Sajip

Changes by Vinay Sajip : -- status: open -> closed ___ Python tracker ___ ___

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-27 Thread Dan McCombs

Dan McCombs added the comment: Thanks Brett. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-27 Thread Brett Cannon

Brett Cannon added the comment: I'll revert the two commits then and close both this and #26664 when I have a chance. -- ___ Python tracker ___

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-27 Thread Dan McCombs

Dan McCombs added the comment: Yes, reverting cfc66e37eb8e and 0f1ac94d2f98 should resolve #26664. -- ___ Python tracker ___

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-27 Thread Brett Cannon

Brett Cannon added the comment: So just to be clear, cfc66e37eb8e and 0f1ac94d2f98 should be reverted? No other changes? And will this fix issue #26664 or affect it in any way? -- assignee: -> brett.cannon status: closed -> open ___ Python tracker

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-27 Thread Dan McCombs

Dan McCombs added the comment: I somehow missed the comment on 2016-04-01, I apologize for being late to look at this. Xiang is right, this patch should be reverted. It looks like the issue reported was originally brought on by an activate.fish being used from a Python after the patch in

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-27 Thread Xiang Zhang

Xiang Zhang added the comment: The original behaviour is right. __VENV_PROMPT__ is meant to be a placeholder, not a variable interpreted by shell. I think this patch should be reverted. Related issue is #26664. -- nosy: +xiang.zhang ___ Python

[issue26348] activate.fish sets VENV prompt incorrectly

2016-04-01 Thread Vinay Sajip

Vinay Sajip added the comment: Implementing this patch has led to another issue being raised: #26664. Dan - would you care to take a look and comment? Thanks. -- ___ Python tracker

[issue26348] activate.fish sets VENV prompt incorrectly

2016-02-13 Thread Roundup Robot

Roundup Robot added the comment: New changeset cfc66e37eb8e by Vinay Sajip in branch '3.5': Fixes #26348: Corrected typos in activate.fish script. https://hg.python.org/cpython/rev/cfc66e37eb8e New changeset 0f1ac94d2f98 by Vinay Sajip in branch 'default': Fixes #26348: Merged fix from 3.5.

[issue26348] activate.fish sets VENV prompt incorrectly

2016-02-13 Thread Vinay Sajip

Changes by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26348] activate.fish sets VENV prompt incorrectly

2016-02-12 Thread Dan McCombs

New submission from Dan McCombs: Currently, the activate.fish VENV script sets fish's prompt to be prepended with a literal "__VENV_PROMPT__" rather than the contents of the $__VENV_PROMPT__ variable as intended. The attached patch simply adds the missing "$" to the variable in the