[issue26355] Emit major version based canonical URLs for docs

Changes by Donald Stufft : -- pull_requests: +1028 ___ Python tracker ___ ___

[issue26355] Emit major version based canonical URLs for docs

Matthias Bussonnier added the comment: > turn my "we should do this" idea into a change we've actually made :) Looking forward to being able to do this more on GitHub as I am more familiar with git. Good luck for the transition, I'm pretty sure there will be some hard time in the next few

[issue26355] Emit major version based canonical URLs for docs

Nick Coghlan added the comment: Matthias - thanks for figuring out how to turn my "we should do this" idea into a change we've actually made :) -- ___ Python tracker

[issue26355] Emit major version based canonical URLs for docs

Matthias Bussonnier added the comment: > OK, I'm marking this as closed, since it's as resolved as we can make it > through a *CPython* change. Thanks you Nick, I appreciate the time you took to do that. ANd thank you Berker for the review. -- ___

[issue26355] Emit major version based canonical URLs for docs

Roundup Robot added the comment: New changeset e8455e7137b9bd63d4c0183558161dba6ea00d32 by Nick Coghlan in branch '2.7': Issue #26355: Specify canonical URLs in docs pages https://github.com/python/cpython/commit/e8455e7137b9bd63d4c0183558161dba6ea00d32 --

[issue26355] Emit major version based canonical URLs for docs

Nick Coghlan added the comment: OK, I'm marking this as closed, since it's as resolved as we can make it through a *CPython* change. Since the old branches aren't autobuilt anymore, adding a canonical URL reference to them would presumably be a matter of running a script over the built docs.

[issue26355] Emit major version based canonical URLs for docs

Roundup Robot added the comment: New changeset a47e20b636d2a5559e5831c6805df3cba1ddb2a1 by Nick Coghlan in branch '3.5': Issue #26355: Specify canonical URLs in docs pages https://github.com/python/cpython/commit/a47e20b636d2a5559e5831c6805df3cba1ddb2a1 --

[issue26355] Emit major version based canonical URLs for docs

Roundup Robot added the comment: New changeset b07d454e45a2 by Nick Coghlan in branch '2.7': Issue #26355: Specify canonical URLs in docs pages https://hg.python.org/cpython/rev/b07d454e45a2 -- ___ Python tracker

[issue26355] Emit major version based canonical URLs for docs

Roundup Robot added the comment: New changeset a47e20b636d2a5559e5831c6805df3cba1ddb2a1 by Nick Coghlan in branch 'master': Issue #26355: Specify canonical URLs in docs pages https://github.com/python/cpython/commit/a47e20b636d2a5559e5831c6805df3cba1ddb2a1 New changeset

[issue26355] Emit major version based canonical URLs for docs

Roundup Robot added the comment: New changeset c63b09833141 by Nick Coghlan in branch '3.5': Issue #26355: Specify canonical URLs in docs pages https://hg.python.org/cpython/rev/c63b09833141 New changeset 80970cf56048 by Nick Coghlan in branch '3.6': Merge issue #26355 fix from Python 3.5

[issue26355] Emit major version based canonical URLs for docs

Nick Coghlan added the comment: Looks good to me, so I'll apply these right now :) -- ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Changes by Nick Coghlan : -- assignee: docs@python -> ncoghlan stage: patch review -> commit review ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Changes by Matthias Bussonnier : Added file: http://bugs.python.org/file46565/cannonical-doc-for-2.6.patch ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Changes by Matthias Bussonnier : Added file: http://bugs.python.org/file46564/cannonical-doc-for-2.7.patch ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Matthias Bussonnier added the comment: Updated patch to take comments into account (added space before /> for consistency). I'm still unfamiliar with hg so let me know if I did anything wrong. -- Added file: http://bugs.python.org/file46563/cannonical-doc-for-3.4plus.patch

[issue26355] Emit major version based canonical URLs for docs

Changes by Matthias Bussonnier : Removed file: http://bugs.python.org/file46426/cannonical-doc-for-3.4plus.patch ___ Python tracker

[issue26355] Emit major version based canonical URLs for docs

Nick Coghlan added the comment: OK, I've marked 2.7 and 3.5+ as the minimal set of versions to get the change via the CPython source repo. However, looking at the results of https://www.google.com/search?q=python+httplib and https://www.google.com/search?q=python+http+client I think it's

[issue26355] Emit major version based canonical URLs for docs

Berker Peksag added the comment: Patch looks good to me too, thanks! Just left a super minor comment on Rietveld. You might want to commit this to 3.5+ because we don't daily build 3.4 docs anymore: https://github.com/python/docsbuild-scripts/blob/master/build_docs.py#L30 I didn't see any

[issue26355] Emit major version based canonical URLs for docs

Matthias Bussonnier added the comment: Thanks Nick, I can work on the similar patch for Python 2.7. I'll wait for the migration to GitHub which IIRC should be soon. Side question, is there some metrics (like google analytics) to know how much traffic there is on older Python docs and if it's

[issue26355] Emit major version based canonical URLs for docs

Nick Coghlan added the comment: Thanks Matthias! Regarding 2v3, the layout differences aren't a problem, since the canonical URLs are separate (/2/* vs /3/*). That's one of the benefits I actually hope for with this change - due to PEP 430, deep links still go to the Python 2 documentation

[issue26355] Emit major version based canonical URLs for docs

Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Manuel Krebber added the comment: Sorry, I accidentally replied to the worng issue -.- -- ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Changes by Manuel Krebber : Removed file: http://bugs.python.org/file46428/slot-wrapper-types.patch ___ Python tracker ___

[issue26355] Emit major version based canonical URLs for docs

Manuel Krebber added the comment: I create the last diff without creating a commit, so maybe this one works better. -- nosy: +Wheerd Added file: http://bugs.python.org/file46428/slot-wrapper-types.patch ___ Python tracker

[issue26355] Emit major version based canonical URLs for docs

Matthias Bussonnier added the comment: Here is a patch that add a canonical link to the current documentation that should apply cleanly to 3.4 and above. I can do similar for older versions. -- keywords: +patch Added file:

[issue26355] Emit major version based canonical URLs for docs

Matthias Bussonnier added the comment: Does this have to be implemented on the doc build of EOL pythons versions (like 2.6), or can it be a script which is ran once on these old docs ? One of the issues I had trying to implement that on other projects was that you don't know in advance what

[issue26355] Emit major version based canonical URLs for docs

Nick Coghlan added the comment: Belatedly following up on this, yeah, the RTFD page indicates that the header link should look like: http://docs.python.org/3/"> -- ___ Python tracker

[issue26355] Emit major version based canonical URLs for docs

New submission from Nick Coghlan: Based on a recent comment on one of the mailing lists, I spent a bit of time looking into canonical URLs and their implications for how search engines treat versioned documentation. The most relevant resource for that in relation to the CPython docs appears

[issue26355] Emit major version based canonical URLs for docs

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___

[issue26355] Emit major version based canonical URLs for docs

Georg Brandl added the comment: So we'd have to add a tag? Should be easy. -- ___ Python tracker ___ ___

[issue26355] Emit major version based canonical URLs for docs

Changes by Nick Coghlan : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker ___