[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: > bpo-26544: Make platform.libc_ver() less slow (GH-10868) > https://github.com/python/cpython/commit/8687bd86e6f138ef0699a1e9f3f9555765949b51 "Coarse benchmark on Fedora 29: 1.6 sec => 0.1 sec." Oops, my benchmark in the commit message was wrong, it

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: New changeset 8687bd86e6f138ef0699a1e9f3f9555765949b51 by Victor Stinner in branch '2.7': bpo-26544: Make platform.libc_ver() less slow (GH-10868) https://github.com/python/cpython/commit/8687bd86e6f138ef0699a1e9f3f9555765949b51 --

[issue26544] platform.libc_ver() returns incorrect version number

Change by STINNER Victor : -- pull_requests: +10104 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: Seems the only difference between PR 8952 and PR 9062 is additional tests. This is not important. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

Ned Deily added the comment: This is now only open and a release blocker for 2.7, correct? -- ___ Python tracker ___ ___

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: > Thank you for merging PRs Victor, but seems you have merged wrong PR for 2.7. Oh. I didn't notice that there were two PRs for 2.7. Do you want to rebase your PR 9062 on 2.7, or revert the commit that I merged? It's up to you ;-) I reopen the issue. It

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: Thank you for merging PRs Victor, but seems you have merged wrong PR for 2.7. -- ___ Python tracker ___

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: Thanks everybody! The issue should now be fixed in all supported branches ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: New changeset 9734024ec65311e33936faa83fb1cb249ef0de9d by Victor Stinner (Miss Islington (bot)) in branch '2.7': bpo-26544: Get rid of dependence from distutils in platform. (GH-8356) (GH-8952)

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: New changeset 1a3eb125dc07a28a5af62446778ed7cca95ed3da by Victor Stinner (Miss Islington (bot)) in branch '3.6': [3.7] bpo-26544: Get rid of dependence from distutils in platform. (GH-8356) (GH-8970) (GH-9061)

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +8522 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Change by miss-islington : -- pull_requests: +8521 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset 20a8392cec2967f15ae81633c1775645b3ca40da by Serhiy Storchaka in branch '3.7': [3.7] bpo-26544: Get rid of dependence from distutils in platform. (GH-8356). (GH-8970)

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: Thanks for adding tests ;-) It now looks better to me ;-) -- ___ Python tracker ___ ___

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset 7917aadb3edb7616d6164c5eaba24df6ac0a5fc6 by Serhiy Storchaka in branch 'master': bpo-26544: Add test for platform._comparable_version(). (GH-8973) https://github.com/python/cpython/commit/7917aadb3edb7616d6164c5eaba24df6ac0a5fc6 --

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +8446 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: Would it be possible to add a few tests on platform._comparable_version()? It would make me more confortable for backports. -- ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +8444 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +8443 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Change by miss-islington : -- pull_requests: +8428 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset 7d81e8f5995df6980a1a02923e224a481375f130 by Serhiy Storchaka in branch 'master': bpo-26544: Get rid of dependence from distutils in platform. (GH-8356) https://github.com/python/cpython/commit/7d81e8f5995df6980a1a02923e224a481375f130

[issue26544] platform.libc_ver() returns incorrect version number

Matthias Klose added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Marc-Andre Lemburg added the comment: I added a comment to the PR, but other than that I think it's good to go. -- ___ Python tracker ___

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: I'll merge it if it looks good to you. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26544] platform.libc_ver() returns incorrect version number

Matthias Klose added the comment: fine! what prevents merging and backporting this issue? -- ___ Python tracker ___ ___

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: platform-no-distutils.diff restores the original bug: "2.9" > "2.10". PR 8356 removes the dependency from distutils and use a sophisticated function for parsing versions. -- ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

Change by Matthias Klose : Added file: https://bugs.python.org/file47755/platform-no-distutils.diff ___ Python tracker ___ ___

[issue26544] platform.libc_ver() returns incorrect version number

Matthias Klose added the comment: proposed patch attached -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Matthias Klose added the comment: no, it's not fixed at all. Setting as a release blocker for 3.6 and 3.7. -- keywords: +3.6regression, 3.7regression nosy: +benjamin.peterson, ned.deily priority: normal -> release blocker ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +7891 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Matthias Klose added the comment: a tuple comparison should be good enough -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26544] platform.libc_ver() returns incorrect version number

Matthias Klose added the comment: please don't close this yet. the patch introduces a dependency on the distutils package. I don't see any reason to compare the libc version as a python egg version, so please avoid that. if we need to have a module to compare arbitrary version strings,

[issue26544] platform.libc_ver() returns incorrect version number

STINNER Victor added the comment: Can we close this issue? It seems like the bug has been fixed, no? -- nosy: +vstinner ___ Python tracker ___

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset b1e6e5615a8e82fcf569368fac5c5b0385929855 by Serhiy Storchaka in branch '2.7': bpo-26544: Fixed implementation of platform.libc_ver(). (GH-7684). (GH-8193) (GH-8196)

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset d73497ba52171bc8f786a70ecf50d3104b596221 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-26544: Fixed implementation of platform.libc_ver(). (GH-7684). (GH-8193) (GH-8195)

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +7748 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Change by miss-islington : -- pull_requests: +7747 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset 7c43b801503c802ed6ea4b811f5bc73791249d94 by Serhiy Storchaka in branch '3.7': [3.7] bpo-26544: Fixed implementation of platform.libc_ver(). (GH-7684). (GH-8193)

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- pull_requests: +7745 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: New changeset 2a9b8babf0d09946ebebfdb2931cc0d3db5a1d3d by Serhiy Storchaka in branch 'master': bpo-26544: Fixed implementation of platform.libc_ver(). (GH-7684) https://github.com/python/cpython/commit/2a9b8babf0d09946ebebfdb2931cc0d3db5a1d3d --

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___ ___

[issue26544] platform.libc_ver() returns incorrect version number

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +7297 stage: -> patch review ___ Python tracker ___ ___

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: I agree that the strategy used for platform.libc_ver() is not perfect. But the implementation has bugs that make it useless. The following PR fixes two bugs in the implementation: 1) Version numbers compared as strings. 2) Versions that are located on the

[issue26544] platform.libc_ver() returns incorrect version number

Serhiy Storchaka added the comment: I need the glibc version for skipping a test if run with glibc containing a bug (see issue31630 and issue33630). platform.libc_ver() is not usable, it always returns '2.9' (the version that has bugs), while the actual version on my computer is '2.25' (the

[issue26544] platform.libc_ver() returns incorrect version number

Nathaniel Smith added the comment: > The purpose of the function was to determine the minimum libc compatibility > requirements of the executable. For what it's worth, I didn't know this, the pip authors obviously didn't know this, and after rereading the docs just now I still can't quite

[issue26544] platform.libc_ver() returns incorrect version number

Marc-Andre Lemburg added the comment: At the time the code was written, libc and glibc were in wide spread use, so it's not surprising that it doesn't work well for other C libs. Note that the routine returns the highest libc version number used and required by the executable (usually the

[issue26544] platform.libc_ver() returns incorrect version number

Nathaniel Smith added the comment: We just ran into this in pip -- https://github.com/pypa/pip/pull/3836 I'd really recommend dropping the current "grovel through the binary doing a regex search" strategy -- it's incredibly error prone, and AFAICT doesn't really give any value. This code OTOH

[issue26544] platform.libc_ver() returns incorrect version number

Marc-Andre Lemburg added the comment: Adding other Python versions as well, since this is a bug. -- versions: +Python 2.7, Python 3.4, Python 3.6 ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

Marc-Andre Lemburg added the comment: True. At the time the code was written, this was not an issue :-) Is the libc version information documented somewhere ? If so, we could probably add a better parser for it. -- ___ Python tracker

[issue26544] platform.libc_ver() returns incorrect version number

Changes by Ned Deily : -- nosy: +lemburg ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26544] platform.libc_ver() returns incorrect version number

New submission from Thomas Waldmann: platform.libc_ver() is trivially broken as it uses string comparison internally to determine the maximum libc version number (which is obviously broken as "2.9" > "2.10"). -- components: Library (Lib) messages: 261624 nosy: Thomas.Waldmann