[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Changes by koobs : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Changes by Xavier de Gaye : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Roundup Robot added the comment: New changeset 5aff28f33b2a by Xavier de Gaye in branch '3.5': Issue #26662: Set PYTHON_FOR_GEN in configure https://hg.python.org/cpython/rev/5aff28f33b2a New changeset a290f992e69a by Xavier de Gaye in branch 'default': (merge from 3.5) Issue #26662: Set

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Xavier de Gaye added the comment: Patch with a new error message. -- Added file: http://bugs.python.org/file43829/py_for_gen_26662_3.patch ___ Python tracker

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: I think that error message would be okay. -- ___ Python tracker ___ ___

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Xavier de Gaye added the comment: Issue 24034 is a duplicate. -- ___ Python tracker ___ ___ Python-bugs-list

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Xavier de Gaye added the comment: So the error message could be ('$@' being the target): Cannot generate $@, python not found ! To skip re-generation of $@ run 'make touch' or 'make -t $@'. Otherwise, set python in PATH and run configure or run make with PYTHON_FOR_GEN=python. Martin, what do

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: The new patch looks good enough. The main reason I complained about the error message is that it sounds like you need Python in order to build Python. Obviously you need Python to run a modified file like typeslots.py, but there is supposed to be an

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Xavier de Gaye added the comment: Following (and thanks to :) Martin's review and comments, this new patch: * does not use the not portable '-e' echo option * uses single quotes (') to avoid the escaping * improves the error message “make touch” does not always fix the problem, for example when

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: The PYTHON_FOR_GEN scheme seems reasonable to me, as is changing the way typeslots script is run. I do wonder about the advice in the message. If I ran into the problem, I would probably either override PYTHON_FOR_GEN when running Make, or try something like

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Xavier de Gaye added the comment: Forgot to say that with the patch and no python in $PATH, the following error message is output: $ touch Include/typeslots.h $ make Cannot generate Objects/typeslots.inc, python not found ! Re-run configure with python in PATH. make: ***

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Xavier de Gaye added the comment: This patch follows the first mechanism listed by Martin. The change in configure.ac fixes the problem described by Victor, it does not generate an empty Objects/typeslots.inc file when python is not found that would cause the cryptic " : invalid slot offset"

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: Survey of different mechanisms for running Python to generate files: Tools/scripts/generate_opcode_h.py and Parser/asdl_c.py: configure.ac tries python3.6, python3, python, etc commands. It either runs the scripts with what it finds, or substitutes an “echo”

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

STINNER Victor added the comment: Right, I built Python on FreeBSD, it's likely that make was not GNU make. -- ___ Python tracker ___

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Chi Hsuan Yen added the comment: Thanks! It's now working find with `make touch` :) -- ___ Python tracker ___

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: Victor: Gnu Make has a special “.DELETE_ON_ERROR” target that will cause Objects/typeslots.inc to be removed if the “python” command fails, which is slightly better than truncating it. See delete-on-error.patch. It looks like you were not using Gnu Make, but

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Chi Hsuan Yen added the comment: Hit by missing `python` command from Python/makeopcodetargets.py, too. Is `make touch` the correct way? -- nosy: +Chi Hsuan Yen ___ Python tracker

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: Maybe the configure.ac code for generating opcode.h is a better alternative. It looks like it prints a warning but would continue with the build: if test "$PYTHON" = not-found; then OPCODEHGEN="@echo python: $PYTHON! cannot run

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

STINNER Victor added the comment: > Typeslots.inc is listed in the .hgtouch file, so you might be able to work > around by running “make touch” before building. My initial issue is that "import ssl" fails with : invalid slot offset. This error is really strange and Google doesn't know it. I

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Martin Panter added the comment: Typeslots.inc is listed in the .hgtouch file, so you might be able to work around by running “make touch” before building. I noticed there are other boostrap scripts that require a “python” command via various mechanisms, e.g. Python/makeopcodetargets.py is

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Changes by STINNER Victor : -- components: +Build ___ Python tracker ___ ___

[issue26662] configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc

Changes by STINNER Victor : -- title: FreeBSD: "invalid slot offset" error on _ssl, _curses_panel and _testmultiphase extensions -> configure/Makefile doesn't check if "python" command works, needed to build Objects/typeslots.inc