[issue26901] Argument Clinic test is broken

Serhiy Storchaka added the comment: Thank you Pablo and Victor! I do not mind backporting to 3.6. Argument Clinic still can take fixes, and they can add new tests. -- ___ Python tracker

[issue26901] Argument Clinic test is broken

STINNER Victor added the comment: We decided to only fix 3.7 and master branches, not 3.6 and older: https://github.com/python/cpython/pull/9048 The initial issue has been fixed, so I close the issue. A new issue might be opened if someone wants to extend the existing test suite

[issue26901] Argument Clinic test is broken

STINNER Victor added the comment: New changeset 1e921236d7ecc77299d34380d6a2159e9db05a1a by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-26901: Fix the Argument Clinic test suite (GH-8879) (GH-9048)

[issue26901] Argument Clinic test is broken

STINNER Victor added the comment: > Any chance to fix Argument Clinic test? Without this we can't add new > features, fix bugs and add tests for searching new bugs. This is critical for > further converting to Argument Clinic. Done in master branch. But test_clinic.py is really basic, it

[issue26901] Argument Clinic test is broken

Change by miss-islington : -- pull_requests: +8510 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26901] Argument Clinic test is broken

STINNER Victor added the comment: New changeset 65fc98e7b1f62c2e621f04780a3a77c3498cc195 by Victor Stinner in branch 'master': bpo-26901: Fix the Argument Clinic test suite (GH-8879) https://github.com/python/cpython/commit/65fc98e7b1f62c2e621f04780a3a77c3498cc195 --

[issue26901] Argument Clinic test is broken

STINNER Victor added the comment: Pablo, Serhiy: there are now 2 PR (one written by Pablo, one by me). Would you mind to have a look and tell me what is your preferred PR? My PR is based on Pablo's PR, I just changed how the tests are run to make sure that they are run on *all* CIs, not

[issue26901] Argument Clinic test is broken

Change by STINNER Victor : -- pull_requests: +8356 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26901] Argument Clinic test is broken

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +8300 stage: -> patch review ___ Python tracker ___ ___

[issue26901] Argument Clinic test is broken

Yaron de Leeuw added the comment: I have done some diving and git bisecting into this. There are at least two issues: 1. `Clinic.__init__` no longer works without passing in a filename. Because soon after `if filename` in line 1726 [1] it calls `d('file')` which only works if there is a

[issue26901] Argument Clinic test is broken

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26901] Argument Clinic test is broken

Serhiy Storchaka added the comment: Any chance to fix Argument Clinic test? Without this we can't add new features, fix bugs and add tests for searching new bugs. This is critical for further converting to Argument Clinic. -- priority: high -> critical

[issue26901] Argument Clinic test is broken

Larry Hastings added the comment: I will admit that even during development I rarely used Clinic's test suite. My test suite is: make a change, then run Clinic over all of CPython and do a diff. If nothing changed then Clinic is still working. --

[issue26901] Argument Clinic test is broken

Zachary Ware added the comment: The clinic tests should probably be integrated into the regrtest suite, since clinic is integrated into the build process. -- nosy: +zach.ware ___ Python tracker

[issue26901] Argument Clinic test is broken

New submission from Serhiy Storchaka: $ ./python Tools/clinic/clinic_test.py Error: Destination does not exist: 'file' It works in 3.4. -- components: Argument Clinic, Tests messages: 264595 nosy: larry, serhiy.storchaka priority: high severity: normal status: open title: Argument