[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: Any backport must include the bugfix in #27821. -- ___ Python tracker ___

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: Yes. If I decide to do a backport to either 3.5 or 2.7, I can reopen or just commit. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: -Python 2.7, Python 3.5 ___ Python

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: Can this issue be closed? -- ___ Python tracker ___ ___ Python-bugs-list

[issue27173] Modern Unix key bindings for IDLE

Roundup Robot added the comment: New changeset 792e3294b59e by Terry Jan Reedy in branch 'default': Issue #27173: Fix error in test_config that caused test_idle to fail. https://hg.python.org/cpython/rev/792e3294b59e -- ___ Python tracker

[issue27173] Modern Unix key bindings for IDLE

Roundup Robot added the comment: New changeset e6e6c71776b0 by Terry Jan Reedy in branch 'default': Issue #27173: Add 'IDLE Modern Unix' to the built-in key sets. https://hg.python.org/cpython/rev/e6e6c71776b0 -- nosy: +python-dev ___ Python tracker

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: The attached patch has a new function current_colors_and_keys that combines ideas and code from both CurrentTheme and CurrentKeys. The latter are now trivial wrappers. It has a new test_config that tests both this function and _warn. The changes to

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: After committing the patch for this issue I'm going to refactor the code related to getting/setting theme/keys settings. For now it is too complicated, the logic is scattered between two files, some code is duplicated. --

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: Seems to be working correctly now, so I will review the code in detail. I will look into extracting a common get_theme_keys function and editing the long docstring currently attached to CurrentTheme. I want to look at paired functions in configdialog, such

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: Updated patch addresses your comments Terry. Since CurrentTheme checks that the corresponding section exists, I no longer think it is buggy. -- Added file: http://bugs.python.org/file43587/idle_modern_unix_key_set5.patch

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: I rebooted and reran build in case this was another funny heisenbug. It isn't. Before patch, start 3.6 repository IDLE. Click Options, Configure IDLE, and Keys tab. Look at 'Use a Custom Key Set'. It says 'Terry', which is correct. After patch: repeat. It

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: I can't reproduce your issue (or understand it correctly). Could you please show the [Keys] section in your config-main.cfg? -- ___ Python tracker

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: The change in v4 is the addition of self.AddChangedItem('main', 'Keys', 'name2', '') There is a bug in the get keys function. After applying, when I restart IDLE and go to 'Keys', my custom key set is 'Modern Unix' instead of 'Terry'. It is still

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27173] Modern Unix key bindings for IDLE

Ned Deily added the comment: "Please confirm that Classic OSX is the right choice over Classic Mac" It is. At least, when we install IDLE on OS X, Clsssic OS X is the default set. I don't know why Classic Mac exists; I'm guessing it is left over from Mac OS 9 days (pre OS X). --

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: Ned, Serhiy's patch 4 solves one of your concerns in #20580 with +@staticmethod +def DefaultKeys(): +if sys.platform[:3] == 'win': +return 'IDLE Classic Windows' +elif sys.platform == 'darwin': +return 'IDLE

[issue27173] Modern Unix key bindings for IDLE

Changes by Serhiy Storchaka : -- dependencies: +IDLE: Fix deletion of custom themes and key bindings ___ Python tracker ___

[issue27173] Modern Unix key bindings for IDLE

Changes by Terry J. Reedy : -- assignee: -> terry.reedy nosy: +markroseman ___ Python tracker ___

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: There was a bug, saving custom key set didn't have any effect if previous key set was IDLE Modern Unix. -- Added file: http://bugs.python.org/file43274/idle_modern_unix_key_set4.patch ___ Python tracker

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: Interesting, I was not able to reproduce a bug if just save as custom theme and apply, but after creating and deleting the second custom theme I got a mystical behavior of IDLE -- radiobuttons are not consistent with comboboxes, OK can't be pressed, etc.

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: I don't understand > idle_modern_unix_key_set3.patch effectively fixes [the bug]. That is the patch that generated the exception I posted. I look forward to contributions to improving the dialog. Redoing the font tab is #24776. The highlight tab is #24781.

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: After applying this patch I'm going to redesign Highlighting and Keys tabs in the Settings dialog. -- ___ Python tracker

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: I'm aware of the bug with deleting current key set. idle_modern_unix_key_set3.patch effectively fixes it. -- ___ Python tracker

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: I looked at _set3 and it looks plausible and possibly complete other than testing. I added something about testing customizations to #27099. This applied cleanly to 3.6. 3.6 started, dialog opened, new key set selected, dialog closed, config-main.cfg looks

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: New patch makes IDLE silently fall back to default key set and adds a note about new key set on Keys configuration tab. -- Added file: http://bugs.python.org/file43091/idle_modern_unix_key_set3.patch ___ Python

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: Original IDLE Dark patch: #24820. Follow-up for cross-version issues (initially for themes, but with a eye to keys, etc): #25313. I intended that 'name2' be future proof (msg252372). I believe my idea was that if it were to point to a future 4th default

[issue27173] Modern Unix key bindings for IDLE

Serhiy Storchaka added the comment: > 3 or more years ago, there was an issue about needing to define pairs like > Control-Key-c and Control-Key-C in order to have crtl + c/C-key work the same > regardless of the caps lock setting. I also remember that the effect of Caps > lock was system

[issue27173] Modern Unix key bindings for IDLE

Terry J. Reedy added the comment: Seems reasonable. 3 or more years ago, there was an issue about needing to define pairs like Control-Key-c and Control-Key-C in order to have crtl + c/C-key work the same regardless of the caps lock setting. I also remember that the effect of Caps lock was

[issue27173] Modern Unix key bindings for IDLE

Changes by Serhiy Storchaka : -- nosy: +terry.reedy ___ Python tracker ___ ___

[issue27173] Modern Unix key bindings for IDLE

New submission from Serhiy Storchaka: The "IDLE Classic Unix" key set in IDLE provides Emacs-like key bindings. But modern Linux environments (KDE, Gnome, etc) use different key bindings in standard editors. Proposed patch provides new key set named "IDLE Modern Unix" that uses key bindings