[issue27182] PEP 519 support in the stdlib

Change by Brett Cannon : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27182] PEP 519 support in the stdlib

Roundup Robot added the comment: New changeset 3417d324cbf9 by Brett Cannon in branch 'default': Issue #27182: Add support for path-like objects to PyUnicode_FSDecoder(). https://hg.python.org/cpython/rev/3417d324cbf9 -- ___ Python tracker

[issue27182] PEP 519 support in the stdlib

Changes by Brett Cannon : -- assignee: brett.cannon -> ___ Python tracker ___ ___

[issue27182] PEP 519 support in the stdlib

Brett Cannon added the comment: The os and os.path modules are now done! The means PEP 519 is finished. At this point individual modules will need to be checked to see if they do (not) support os.PathLike. -- ___ Python tracker

[issue27182] PEP 519 support in the stdlib

Brett Cannon added the comment: Here is an odd patch because I don't know where else to put it ATM that adds the remaining support in the os module/package not covered by other issues w/ patches (specifically os.walk() and os.fwalk()). I think everything else simply falls through thanks to

[issue27182] PEP 519 support in the stdlib

Brett Cannon added the comment: Just a quick update: between the patches for issue #26027 and issue #26667, the necessary code to make os.path work with path-like objects is done. At this point I'm just waiting for code reviews on those patches. --

[issue27182] PEP 519 support in the stdlib

Changes by Brett Cannon : -- dependencies: -Add a "What's New" entry for PEP 519 ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Changes by Brett Cannon : -- assignee: -> brett.cannon dependencies: +Add a "What's New" entry for PEP 519 ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Roundup Robot added the comment: New changeset 6239673d5e1d by Brett Cannon in branch 'default': Issue #27182: Document os.PathLike. https://hg.python.org/cpython/rev/6239673d5e1d -- ___ Python tracker

[issue27182] PEP 519 support in the stdlib

Brett Cannon added the comment: Functions that only accept file descriptors should not be updated to work with __fspath__() as it will never return an int/fd. As for Ethan's suggestion, are you saying you want to toss the str/bytes check from os.fspath()? If so then you will need to go to

[issue27182] PEP 519 support in the stdlib

Jelle Zijlstra added the comment: If we do that, then os.* functions that accept fds would also work on objects whose __fspath__ method returns an integer. I don't think that is desirable (I was just writing a test to ensure that fspath returning an integer throws an error). --

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: Currently, os.fspath will raise an exception if the thing passed in is not str/bytes/PathLike, and that error message will proclaim that str or bytes or PathLike is required; however, this is not true in cases such as Path (which doesn't allow bytes), and

[issue27182] PEP 519 support in the stdlib

Changes by Ethan Furman : -- Removed message: http://bugs.python.org/msg267280 ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Jelle Zijlstra added the comment: Attached patch fixes the undefined variable and adds additional tests. -- Added file: http://bugs.python.org/file43201/issue27182-path_type.patch ___ Python tracker

[issue27182] PEP 519 support in the stdlib

Jelle Zijlstra added the comment: In the patch that was just committed, the path_type variables are undefined (os.py lines 892 and 908). There is also no test for these error cases—we should test the cases where the path has no __fspath__ or does not return a bytes or str. --

[issue27182] PEP 519 support in the stdlib

Roundup Robot added the comment: New changeset 00991aa5fdb5 by Ethan Furman in branch 'default': issue27182: update fsencode and fsdecode for os.path(); patch by Dusty Phillips https://hg.python.org/cpython/rev/00991aa5fdb5 -- nosy: +python-dev ___

[issue27182] PEP 519 support in the stdlib

Jelle Zijlstra added the comment: This patch makes the Python and C versions of open()/io.open() support the fspath protocol. -- keywords: +patch Added file: http://bugs.python.org/file43156/issue27182-open.patch ___ Python tracker

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: Sorry, Serhiy, I had my module names mixed up. `nt` and `posix` are the same, but `ntpath` and `posixpath` are not (I may have those first two names wrong again, but hopefully you get the idea). -- ___ Python tracker

[issue27182] PEP 519 support in the stdlib

Jelle Zijlstra added the comment: FYI, I'm working on a patch for builtins.open to call PyOS_FSPath. -- nosy: +Jelle Zijlstra ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: Nope. There is a posixpath.py and an ntpath.py, and they are not the same. -- ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Serhiy Storchaka added the comment: Isn't the nt module just an alias of the posix module? -- ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: os.fspath(): issue27186 -- dependencies: +add os.fspath() ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

Changes by Ethan Furman : -- dependencies: +Support Path objects in the posix module, Support path objects in the nt module, Update importlib to accept pathlib.Path objects type: -> behavior versions: +Python 3.6 ___ Python

[issue27182] PEP 519 support in the stdlib

Changes by Ethan Furman : -- type: behavior -> enhancement ___ Python tracker ___ ___

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: nt module: issue27184 -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: importlib: issue26667 -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27182] PEP 519 support in the stdlib

Ethan Furman added the comment: posix module: issue26027 -- ___ Python tracker ___ ___ Python-bugs-list

[issue27182] PEP 519 support in the stdlib

New submission from Ethan Furman: Meta issue to track adding PEP 519 support in the various stdlib modules. -- messages: 266891 nosy: brett.cannon, ethan.furman, serhiy.storchaka priority: normal severity: normal status: open title: PEP 519 support in the stdlib