[issue27200] make doctest in CPython has failures

Julien Palard added the comment: Closing PR and issue as already fixed and now enforced by CI. Thanks again Marco for those already-merged fixes, it helped a lot ending the work at the last PyCon Fr sprints. -- resolution: -> fixed stage: patch review -> resolved status: open ->

[issue27200] make doctest in CPython has failures

Terry J. Reedy added the comment: At the moment, the dependent issues are closed and there is just one open PR on this issue. Julian, I am nosying you here because you merged #34962, which is properly a dependency of this. -- dependencies: +make doctest does not pass :/ nosy: +mdk

[issue27200] make doctest in CPython has failures

Karthikeyan Singaravelan added the comment: Sorry to bump this but to add some more context doctest related issues were fixed in issue34962 and is now enforced in CI. -- nosy: +xtreak ___ Python tracker

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: New changeset e65fcde85abf6617508f2d6b77020e24b8ca6f6b by Berker Peksag (Marco Buttu) in branch 'master': bpo-27200: Fix several doctests (GH-604) https://github.com/python/cpython/commit/e65fcde85abf6617508f2d6b77020e24b8ca6f6b --

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: New changeset 7b2491a6aa5cdc1f8f9e3fd9df91f29ee69aa982 by Berker Peksag (Marco Buttu) in branch 'master': bpo-27200: Fix pathlib, ssl, turtle and weakref doctests (GH-616) https://github.com/python/cpython/commit/7b2491a6aa5cdc1f8f9e3fd9df91f29ee69aa982

[issue27200] make doctest in CPython has failures

Changes by Marco Buttu : -- pull_requests: +727 ___ Python tracker ___ ___

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: New changeset b2a7c2f9862b28cf5db11ef837646ef0c589955c by Berker Peksag (Marco Buttu) in branch 'master': bpo-27200: fix configparser, copyreg and ctypes doctests (#240) https://github.com/python/cpython/commit/b2a7c2f9862b28cf5db11ef837646ef0c589955c

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: New changeset 909a6f626ff343937cd3f06fda996870e7890724 by Berker Peksag (Marco Buttu) in branch 'master': bpo-27200: Fix doctests in programming.rst and datetime.rst (#401) https://github.com/python/cpython/commit/909a6f626ff343937cd3f06fda996870e7890724

[issue27200] make doctest in CPython has failures

Changes by Marco Buttu : -- pull_requests: +509 ___ Python tracker ___ ___

[issue27200] make doctest in CPython has failures

Changes by Marco Buttu : -- pull_requests: +499 ___ Python tracker ___ ___

[issue27200] make doctest in CPython has failures

Changes by Marco Buttu : -- pull_requests: +332 ___ Python tracker ___ ___

[issue27200] make doctest in CPython has failures

Changes by Marco Buttu : -- pull_requests: +202 ___ Python tracker ___ ___

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: Thank you Raymond for your time. I just want to note that does not distrac the reader, because it is not show in the output. Furthermore, to doctest an example we do not need to add the prompt (>>>): we can use the testcode/testoutput Sphinx directives.

[issue27200] make doctest in CPython has failures

Zachary Ware added the comment: Raymond Hettinger wrote: > Similarly, make sure that clarity and cut-and-pastability don't get lost by > adding ... PS2 prompts that uglify the examples. Note that Sphinx adds a ">>>" button to the upper right of the example that, when clicked, makes all of the

[issue27200] make doctest in CPython has failures

Raymond Hettinger added the comment: Also, please make this 3.7 only. There is no point in going back in time unless an example is found that is actually broken. -- priority: normal -> low versions: -Python 2.7, Python 3.5, Python 3.6 ___ Python

[issue27200] make doctest in CPython has failures

Raymond Hettinger added the comment: Mariatta, would you please add your review comments to the proposed patches. For the most part, we want the patches to make the minimal changes necessary to pass the doctests. Also, clarity of the examples is more important than making the examples

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: Thanks Brett :-) Following the suggestion of Ezio to split the patch in more patches (msg284560), and according to msg284628, here is a first patch for just three files. To run their doctests: $ sphinx-build -b doctest . build/doctest \ library/configparser.rst

[issue27200] make doctest in CPython has failures

Brett Cannon added the comment: I'm -1 on building the docs from Sphinx master as I don't want to complicate our development process to deal with potential broken tooling. Basically if the doctests don't pass on a compiled checkout for the version of Python the docs are being built for then

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: In order for the patches to work for every Python version (see #msg284622 ), I added a new feature to the Sphinx doctest extension, called pyversion. Starting from Sphinx 1.6, it will be possible to specify the Python version in order for the example to be

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: Thinking a little bit about it, I believe that the easiest way to proceed is to make one patch for every file or two, with the only purpose to make their doctests to pass. Otherwise if I make a patch with all the doctest directives, or just with the +SKIP

[issue27200] make doctest in CPython has failures

Ezio Melotti added the comment: > The +SKIP option and the testsetup and teardown directives are not visible in > the output. So feel free to use them when needed :) > But as you can see in issue28860, I was asked to add it. Before going > on, I think we should have a clear policy about it.

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: Hi Ezio, thanks for your time :) The +SKIP option and the testsetup and teardown directives are not visible in the output. The only extra code in the output is sorted(). I agree with you about the use of sorted(), and I think we do not have to add extra code

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: I agree with Ezio. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27200] make doctest in CPython has failures

Ezio Melotti added the comment: I left a few comments on rietveld, In general, if making the doctest pass entails adding superfluous code (e.g. sorted(), , #doctest: +SKIP (if visible), setups/teardowns, or even whole files) or removing details that might be useful (ids or filenames in

[issue27200] make doctest in CPython has failures

Changes by Zachary Ware : -- assignee: Jelle Zijlstra -> stage: -> patch review versions: +Python 3.7 ___ Python tracker ___

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: I isolated all snippets in the unittest.mock documentation, and now all doctests pass without surprises :-) -- Added file: http://bugs.python.org/file45818/issue27200_3rd.patch ___ Python tracker

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: This last patch (make_doctest_ok.patch) makes all doctests pass (Sphinx 1.5, Python 3.6). Before applaying the patch there are 466 failures in 2096 tests, and after we have more tests (2414) and 0 failures. Actually, sometimes 3 tests fail in

[issue27200] make doctest in CPython has failures

Marco Buttu added the comment: Here is a patch that makes all Doc/library/datetime.rst doctests pass. The tests only pass with Python 3.6 and 3.7 (the optional ``timespec`` argument of ``datetime.isoformat()`` has been introduced in Python 3.6). To apply the patch you should agree with issue

[issue27200] make doctest in CPython has failures

Terry J. Reedy added the comment: #10225, still open, has a old 3.2 patch that might be useful. If it is not, it should be closed. Note that Raymond does not like the patch for the sorting help doc. -- ___ Python tracker

[issue27200] make doctest in CPython has failures

Terry J. Reedy added the comment: #28860 has a patch for configparser. Jelle, if you have more patches for some of the items listed above, please upload them so Marco can focus on the others. -- dependencies: +Fixed all the doctest failures in Doc/library/configparser.rst nosy:

[issue27200] make doctest in CPython has failures

Zachary Ware added the comment: Thanks for creating all the patches! If you create further issues for this, feel free to make me nosy. -- ___ Python tracker

[issue27200] make doctest in CPython has failures

Jelle Zijlstra added the comment: Thanks for committing all of these patches! I have local patches for some more tests; I'll try to find some time to upload them. -- ___ Python tracker

[issue27200] make doctest in CPython has failures

Zachary Ware added the comment: All of the current dependencies have been committed. I still see failures in: Doc/faq/programming.rst Doc/library/configparser.rst (also leaves Doc/example.ini) Doc/library/copyreg.rst Doc/library/ctypes.rst Doc/library/datetime.rst Doc/library/functions.rst

[issue27200] make doctest in CPython has failures

Roundup Robot added the comment: New changeset f3a04d19e5cb by Zachary Ware in branch '3.5': Issue #27200: Fix doctests in Doc/library/hashlib.rst https://hg.python.org/cpython/rev/f3a04d19e5cb New changeset d0302d8ecbc1 by Zachary Ware in branch 'default': Issue #27200: Merge with 3.5

[issue27200] make doctest in CPython has failures

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: I have also found some markup errors via 'make doctest' so I agree that this can be helpful :) -- ___ Python tracker

[issue27200] make doctest in CPython has failures

Changes by Jelle Zijlstra : -- assignee: -> Jelle Zijlstra ___ Python tracker ___

[issue27200] make doctest in CPython has failures

R. David Murray added the comment: Yes, the point here is to test the docs, not the code, and is definitely worthwhile. If we can get make doctest to pass, then the docs buildbot can start running it. -- nosy: +r.david.murray ___ Python tracker

[issue27200] make doctest in CPython has failures

Jelle Zijlstra added the comment: I would consider this a test of the quality of the documentation, not of the implementation. It's important that the examples in the documentation are actually correct. For example, a doctest in Doc/library/datetime.rst passes an "hours=" keyword argument to

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: Thanks for all of these patches, but I'm -1 on committing them. We already have an extensive test suite and I'm pretty sure that all of these examples are already tested in Lib/test [*]. Learning reST is already hard for contributors and we shouldn't make it

[issue27200] make doctest in CPython has failures

Jelle Zijlstra added the comment: Added a number of more specific issues with patches. I'll add more patches after the current ones are resolved. -- dependencies: +Failing doctests due to environmental dependencies in Lib/*lib.rst, Failing doctests in Doc/faq/programming.rst, Failing

[issue27200] make doctest in CPython has failures

New submission from Jelle Zijlstra: I'm going to gather together a patch to fix some of these issues. -- messages: 267166 nosy: Jelle Zijlstra, brett.cannon priority: normal severity: normal status: open title: make doctest in CPython has failures