[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

STINNER Victor added the comment: Nice! -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Erlend E. Aasland added the comment: Thanks Luca, for the report, reproducer, and initial patch, Berker for helpful suggestion, and Łukasz, Pablo, & Victor for reviewing and merging. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Pablo Galindo Salgado added the comment: New changeset 2a80893e5c023a73ccd32cc319f4f0404f548c00 by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202) (GH-27943)

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Pablo Galindo Salgado added the comment: New changeset 52702e8ba0d777ac92ec36038213976545c4759e by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202) (GH-27944)

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Łukasz Langa added the comment: New changeset a3c11cebf174e0c822eda8c545f7548269ce7a25 by Erlend Egeberg Aasland in branch 'main': bpo-27334: Fix reference leak introduced by GH-26202 (GH-27942) https://github.com/python/cpython/commit/a3c11cebf174e0c822eda8c545f7548269ce7a25 --

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Change by Erlend E. Aasland : -- pull_requests: +26390 pull_request: https://github.com/python/cpython/pull/27944 ___ Python tracker ___

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Change by Erlend E. Aasland : -- pull_requests: +26389 pull_request: https://github.com/python/cpython/pull/27943 ___ Python tracker ___

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Change by Erlend E. Aasland : -- pull_requests: +26388 pull_request: https://github.com/python/cpython/pull/27942 ___ Python tracker ___

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Pablo Galindo Salgado added the comment: New changeset 7ecd3425d45a37efbc745788dfe21df0286c785a by Erlend Egeberg Aasland in branch 'main': bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202)

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Erlend E. Aasland added the comment: > I believe the reason for this problem is that the exception happened in the > implicit `commit` that is run on exiting the context manager, rather than > inside it. In fact the exception is in the `pass` line rather than in the > `execute` line. This

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Erlend E. Aasland added the comment: > In fact the exception is in the `pass` line rather than in the `execute` line. I can reproduce this without the `pass` line. I've taken the liberty to create a PR based on your patch, Luca. Berker's comments have been addressed in the PR. --