[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Inada Naoki added the comment: New changeset efefe25443c56988841ab96cdac01352123ba268 by Inada Naoki (wim glenn) in branch 'master': bpo-27413: json.tool: Add --no-ensure-ascii option. (GH-17472) https://github.com/python/cpython/commit/efefe25443c56988841ab96cdac01352123ba268 --

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.7 ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Change by wim glenn : -- pull_requests: +16953 pull_request: https://github.com/python/cpython/pull/17472 ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by R. David Murray : -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by R. David Murray : -- nosy: +qingyunha ___ Python tracker ___ ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Daniel Himmelstein : -- pull_requests: +2779 ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Daniel Himmelstein : -- pull_requests: +232 ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Serhiy Storchaka added the comment: The last change just sweeps a problem under a rug. For now json.tool never fails with valid data. But with the --no-ensure-ascii option it can fail when output a string not encodable with the locale encoding. All can work with common cases on common UTF-8

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Berker Peksag added the comment: > If I'm not misreading your comment, this will change the original behavior, > right? Assuming you also change ensure_ascii = not options.no_ensure_ascii to ensure_ascii = options.no_ensure_ascii no, it won't change the original behavior. That way

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg273813 ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Raymond Hettinger : -- assignee: rhettinger -> ___ Python tracker ___

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Wei-Cheng Pan added the comment: 1. Replaced non-ASCII literals to \u 2. Removed failed assertion Test passed with LC_ALL=en_US and LC_ALL=en_US.UTF-8 . I've tried to use locale.getdefaultlocale(), but seems the output string will vary in different locales. -- Added file:

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Wei-Cheng Pan : Removed file: https://bugs.python.org/file44243/json-add-an-option-to-bypass-non-ascii-characters-v3.patch ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Serhiy Storchaka added the comment: Test fails on non-utf8 locale. $ LC_ALL=en_US ./python -m test.regrtest -v -m test_no_ensure_ascii_flag test_json ... == FAIL: test_no_ensure_ascii_flag (test.test_json.test_tool.TestTool)

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Raymond Hettinger added the comment: The patch looks good. If no one else objects soon, I will apply it. -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Wei-Cheng Pan : Removed file: https://bugs.python.org/file43596/json-add-an-option-to-bypass-non-ascii-characters.patch ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Wei-Cheng Pan added the comment: Added doc and test. -- Added file: https://bugs.python.org/file44243/json-add-an-option-to-bypass-non-ascii-characters-v3.patch ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Wei-Cheng Pan added the comment: > The patch needs tests and documentation. Ok, I'll update it later. >> +parser.add_argument('--no-ensure-ascii', action='store_true', >> default=False, >I'd go with ``action='store_false', default=True``. If I'm not misreading your comment, this will

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Berker Peksag added the comment: The patch needs tests and documentation. > +parser.add_argument('--no-ensure-ascii', action='store_true', > default=False, I'd go with ``action='store_false', default=True``. -- nosy: +berker.peksag stage: -> patch review

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Wei-Cheng Pan added the comment: Use "--no-ensure-ascii" instead. -- Added file: http://bugs.python.org/file43596/json-add-an-option-to-bypass-non-ascii-characters.patch ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Changes by Wei-Cheng Pan : Removed file: http://bugs.python.org/file43578/json-add-an-option-to-bypass-non-ascii-characters.patch ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

R. David Murray added the comment: Sorry, yes, that's what I meant. I think it will make it easier to understand and remember if the option uses the same terminology as the function. -- ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

Wei-Cheng Pan added the comment: If the arguments should be aligned with those in dump/load, then maybe "--no-ensure-ascii" is an option? -- ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

R. David Murray added the comment: Maybe name it --no-insure-ascii? Or --insure-ascii=no/yes. (or true/false). -- nosy: +r.david.murray ___ Python tracker

[issue27413] Add an option to json.tool to bypass non-ASCII characters.

New submission from Wei-Cheng Pan: This patch adds a command line option "--no-escape" that allows json.tool to display non-ASCII characters. e.g.: $ echo '"測試"' | python -m json.tool "\u6e2c\u8a66" $ echo '"測試"' | python -m json.tool --no-escape "測試" -- components: Library (Lib)