[issue27505] Missing documentation for setting module __class__ attribute

Nick Coghlan added the comment: Thanks for the PRs! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27505] Missing documentation for setting module __class__ attribute

Nick Coghlan added the comment: New changeset 8f68cb7db37322cfeeb8338e78474e5f25d930c5 by Nick Coghlan (Cheryl Sabella) in branch '3.6': [3.6] bpo-27505: Retrofit module __class__ documentation from 3.7 (GH-5321)

[issue27505] Missing documentation for setting module __class__ attribute

Nick Coghlan added the comment: New changeset 85527cf50a9a4eecaca4022f7c6cb9e0bae1fa5f by Nick Coghlan (Cheryl Sabella) in branch 'master': bpo-27505: Add change notes in module attribute docs (GH-5320)

[issue27505] Missing documentation for setting module __class__ attribute

Change by Cheryl Sabella : -- stage: needs patch -> patch review ___ Python tracker ___

[issue27505] Missing documentation for setting module __class__ attribute

Cheryl Sabella added the comment: Thanks Nick. I've made the PRs for the versionadded and to add __class__ to the 3.6 docs. -- stage: patch review -> needs patch versions: +Python 3.7 -Python 3.5 ___ Python tracker

[issue27505] Missing documentation for setting module __class__ attribute

Change by Cheryl Sabella : -- pull_requests: +5166 ___ Python tracker ___ ___

[issue27505] Missing documentation for setting module __class__ attribute

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +5165 stage: needs patch -> patch review ___ Python tracker ___

[issue27505] Missing documentation for setting module __class__ attribute

Nick Coghlan added the comment: I think the only thing missing for the 3.7 docs now would be a pair of "versionchanged" notes indicating that __class__ has been settable since 3.5, while module level __dir__ and __getattr__ support is new in 3.7. It would also be

[issue27505] Missing documentation for setting module __class__ attribute

Cheryl Sabella added the comment: Nick, It looks like #32225 took care of this documentation change, so I think this can be closed? Thanks! -- ___ Python tracker

[issue27505] Missing documentation for setting module __class__ attribute

Nick Coghlan added the comment: This is still a valid docs issue, although PEP 562's module __getattr__ and __dir__ will provide a simpler alternative for most of the cases that previously required setting the __class__ attribute: https://www.python.org/dev/peps/pep-0562/

[issue27505] Missing documentation for setting module __class__ attribute

Cheryl Sabella added the comment: Hi Nick, I started looking at this issue for documenting #22986 and then found #24912 and #24991. Has anything changed in the code since 2015 that would make these issues (this one and 24991) obsolete? It seems there were a lot of ideas

[issue27505] Missing documentation for setting module __class__ attribute

Changes by Nick Coghlan : -- dependencies: +Improved handling of __class__ assignment ___ Python tracker ___

[issue27505] Missing documentation for setting module __class__ attribute

New submission from Nick Coghlan: Python 3.5 added the ability to set module __class__ attributes by way of http://bugs.python.org/issue22986 However, this isn't covered in the What's New guide or anywhere else in the documentation, and even in the NEWS file it appears under the cryptic title