[issue27558] SystemError with bare `raise` in threading or multiprocessing

Changes by SilentGhost : -- stage: patch review -> resolved ___ Python tracker ___ ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: Thanks for your work too! ;) I agree to close. -- ___ Python tracker ___ ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

STINNER Victor added the comment: Thanks Xiang Zhang. The fix is obvious and simple, but it wasn't easy to identify it ;-) I pushed the fix to Python 3.5 and default (3.6). Python 2.7 doesn't crash, the bare "raise" statement raises the exception: TypeError('exceptions must be old-style

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Roundup Robot added the comment: New changeset ba45fbb16499 by Victor Stinner in branch '3.5': Fix SystemError in "raise" statement https://hg.python.org/cpython/rev/ba45fbb16499 -- nosy: +python-dev ___ Python tracker

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: Victor, upload a new patch, changing the test case to the approach you prefer. ;) -- Added file: http://bugs.python.org/file44137/issue27558_v3.patch ___ Python tracker

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: Thanks for your review, Victor. :) Leave a reply. -- ___ Python tracker ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

STINNER Victor added the comment: I reviewed issue27558_v2.patch, see my comments. -- ___ Python tracker ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Berker Peksag added the comment: Raymond, please stop hijacking issues. This doesn't have anything to do with multiprocessing and there are already four core developers in the nosy list. If you really want to assign it to someone else, please at least wait for a month or ask if they have time

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Raymond Hettinger added the comment: Davin, would you like to finish this one (NEWS and ACKS entries) and get it committed? -- assignee: -> davin nosy: +rhettinger ___ Python tracker

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: Ping. Mind to merge? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Berker Peksag added the comment: The test code in issue27558_v2.patch looks OK to me. -- ___ Python tracker ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: Update the patch with Berker's suggestion: add test in test_threading instead of test_raise. Hope someone is willing to merge this. -- Added file: http://bugs.python.org/file43971/issue27558_v2.patch ___ Python tracker

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: A simple try ... except ... can set the variable to Py_None: >>> import threading >>> def foo(): ... try: ... raise RuntimeError ... except: ... pass ... raise ... >>> threading.Thread(target=foo).start() >>> Exception in

[issue27558] SystemError with bare `raise` in threading or multiprocessing

R. David Murray added the comment: Since ceval already has such a check, I think we should fix it by adding the check as proposed. Investigating whether the codebase could be simplified by making sure that Py_None is always there after startup would be a separate issue, I think, possibly

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: It's reasonable but I'd still like to hear others' voices since it looks more like to me it's the behaviour of raise itself rather than threading that crashes. -- ___ Python tracker

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Berker Peksag added the comment: I would prefer Antti's test case in msg270730 since the bug can be reproduced by using threading module (you can use assert_python_ok() as a helper.) Lib/test_threading.py is probably a better place for the test. -- nosy: +berker.peksag stage: needs

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Xiang Zhang added the comment: Upload a patch. -- keywords: +patch Added file: http://bugs.python.org/file43776/issue27558.patch ___ Python tracker ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

Changes by Emanuel Barry : -- nosy: +davin, ebarry, pitrou stage: -> needs patch title: SystemError inside multiprocessing.dummy Pool.map -> SystemError with bare `raise` in threading or multiprocessing versions: +Python 3.6 -Python 3.2, Python 3.3