[issue27572] Support bytes-like objects when base is given to int()

Change by Serhiy Storchaka : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27572] Support bytes-like objects when base is given to int()

Serhiy Storchaka added the comment: Created PR 779 for the deprecation. -- stage: -> patch review versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue27572] Support bytes-like objects when base is given to int()

Changes by Serhiy Storchaka : -- pull_requests: +683 ___ Python tracker ___ ___

[issue27572] Support bytes-like objects when base is given to int()

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file44841/deprecate_byte_like_support_in_int.patch ___ Python tracker

[issue27572] Support bytes-like objects when base is given to int()

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file44840/deprecate_byte_like_support_in_int.patch ___ Python tracker

[issue27572] Support bytes-like objects when base is given to int()

Serhiy Storchaka added the comment: Here is a patch that deprecates support of bytes-like objects except bytes and bytearray in int(), float(), compile(), eval(), exec(). I'm not arguing for it, this is just for the ground of the discussion. -- Added file:

[issue27572] Support bytes-like objects when base is given to int()

Xiang Zhang added the comment: pypy seems so. [PyPy 5.2.0-alpha0 with GCC 4.8.2] on linux int(memoryview(b'123A'[1:3])) 23 int(memoryview(b'123 '[1:3])) 23 -- ___ Python tracker

[issue27572] Support bytes-like objects when base is given to int()

Serhiy Storchaka added the comment: No, the fix was applied to all maintained versions (2.7 and 3.4+). This means that we need some deprecation period before dropping this feature (if decide to drop it). What about other Python implementations? Are they support byte-likes objects besides

[issue27572] Support bytes-like objects when base is given to int()

R. David Murray added the comment: So less than a year means only some versions of 3.5? So we could drop it in 3.6 and hope we don't break anybody's code? I'm not sure I like that...I think the real problem is the complexity of handling multiple bytes types, and that ought to have a more

[issue27572] Support bytes-like objects when base is given to int()

Serhiy Storchaka added the comment: It looks to me that the support of bytes-like objects besides bytes and bytearray was added accidentally, as a side effect of supporting Unicode. Note, that this support had a bug until issue24802, thus correct support of other bytes-like objects exists

[issue27572] Support bytes-like objects when base is given to int()

R. David Murray added the comment: Since bytes are accepted in both cases, the inconsistency does seem odd. Looking at the history, I think the else statement that checks the types that can be handled was introduced during the initial py3k conversion, and I'm guessing that else was just

[issue27572] Support bytes-like objects when base is given to int()

Xiang Zhang added the comment: It's reasonable. My original intention is to make the behaviour consistent. If the single-argument behaviour is OK with bytes-like objects, why not others? So I think we'd better wait for other developers to see what their opinions are. -- nosy:

[issue27572] Support bytes-like objects when base is given to int()

Martin Panter added the comment: I am torn on this. On one hand, it would be good to be consistent with the single-argument behaviour. But on the other hand, APIs normally accept arbitrary bytes-like objects (like memoryview) to minimise unnecessary copying, whereas this case has to make a

[issue27572] Support bytes-like objects when base is given to int()

Xiang Zhang added the comment: Thanks for the reviews Martin. Change the doc and test. -- Added file: http://bugs.python.org/file43825/bytes_like_support_to_int_v2.patch ___ Python tracker

[issue27572] Support bytes-like objects when base is given to int()

Changes by Xiang Zhang : Added file: http://bugs.python.org/file43790/bytes_like_support_to_int.patch ___ Python tracker ___

[issue27572] Support bytes-like objects when base is given to int()

Changes by Xiang Zhang : Removed file: http://bugs.python.org/file43789/bytes_like_support_to_int.patch ___ Python tracker ___

[issue27572] Support bytes-like objects when base is given to int()

Changes by Xiang Zhang : -- type: -> enhancement ___ Python tracker ___ ___

[issue27572] Support bytes-like objects when base is given to int()

New submission from Xiang Zhang: Right now, int() supports bytes-like objects when *base* is not given: >>> int(memoryview(b'100')) 100 When *base* is given bytes-like objects are not supported: >>> int(memoryview(b'100'), base=2) Traceback (most recent call last): File "", line 1, in