[issue27573] code.interact() should print an exit message

Roundup Robot added the comment: New changeset c4863530cfd6 by Steven D'Aprano in branch 'default': Issue #27573 make the exit message configurable. https://hg.python.org/cpython/rev/c4863530cfd6 -- ___ Python tracker

[issue27573] code.interact() should print an exit message

Steven D'Aprano added the comment: On Thu, Aug 18, 2016 at 12:26:56PM +, Armin Rigo wrote: > ...ah, upon closer inspection, we don't use the ``interact()`` method > anyway. We already copied and tweaked this method: one problem was > that it gives no way to run without printing at least

[issue27573] code.interact() should print an exit message

Armin Rigo added the comment: ...ah, upon closer inspection, we don't use the ``interact()`` method anyway. We already copied and tweaked this method: one problem was that it gives no way to run without printing at least one '\n' of banner at the beginning. Then a more important tweak was

[issue27573] code.interact() should print an exit message

Armin Rigo added the comment: I'm fine with `exitmsg`. I guess it would be a flag (not `None` as you wrote), defaulting to `True`? -- ___ Python tracker

[issue27573] code.interact() should print an exit message

Steven D'Aprano added the comment: On Thu, Aug 18, 2016 at 08:19:25AM +, Armin Rigo wrote: > Can we make the exit message optional? Sure. What API do you prefer? I'm thinking to just give interact() an optional "exitmsg" argument, similar to banner: def interact(banner=None,

[issue27573] code.interact() should print an exit message

Armin Rigo added the comment: Can we make the exit message optional? Otherwise PyPy will need to patch code.py to add the option to not display this message when used as the normal REPL (yes, PyPy uses the plain code.py as its built-in REPL). -- nosy: +arigo

[issue27573] code.interact() should print an exit message

Changes by Steven D'Aprano : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue27573] code.interact() should print an exit message

Ned Deily added the comment: Steven, don't forget to update Misc/NEWS and to close this issue on the bug tracker. Thanks! -- nosy: +ned.deily ___ Python tracker

[issue27573] code.interact() should print an exit message

Roundup Robot added the comment: New changeset 9410dc027505 by Steven D'Aprano in branch 'default': Issue27573 code.interact prints a message when exiting. https://hg.python.org/cpython/rev/9410dc027505 -- nosy: +python-dev ___ Python tracker

[issue27573] code.interact() should print an exit message

Paul Moore added the comment: LGTM. Maybe worth a documentation note - "Changed in 3.6 - added an exit message"? But I'm OK with it as is if you don't think that's worth it. -- nosy: +paul.moore ___ Python tracker

[issue27573] code.interact() should print an exit message

Brett Cannon added the comment: LGTM -- assignee: -> steven.daprano nosy: +brett.cannon ___ Python tracker ___

[issue27573] code.interact() should print an exit message

Steven D'Aprano added the comment: This time, with a patch that includes updated tests. -- Added file: http://bugs.python.org/file43793/code.patch ___ Python tracker

[issue27573] code.interact() should print an exit message

Changes by Steven D'Aprano : Removed file: http://bugs.python.org/file43791/code.patch ___ Python tracker ___

[issue27573] code.interact() should print an exit message

New submission from Steven D'Aprano: Way too often I've lost track of whether I'm in the code.interact() REPL or the original REPL, or hit Ctrl-D once too often, and accidentally quit the real REPL. It is easy to lose track, since the real and imitation REPL both use the same prompts. It