[issue27587] Issues, reported by PVS-Studio static analyzer

Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27587] Issues, reported by PVS-Studio static analyzer

Roundup Robot added the comment: New changeset 51627344fc58 by Berker Peksag in branch '3.5': Issue #27587: Move null pointer check earlier in _PyState_AddModule() https://hg.python.org/cpython/rev/51627344fc58 New changeset 7d90bf4780ff by Berker Peksag in branch 'default': Issue #27587: Merge

[issue27587] Issues, reported by PVS-Studio static analyzer

STINNER Victor added the comment: issue27587_pystate_addmodule_v2.diff LGTM. -- ___ Python tracker ___ ___

[issue27587] Issues, reported by PVS-Studio static analyzer

Berker Peksag added the comment: Here is an updated patch. -- Added file: http://bugs.python.org/file44141/issue27587_pystate_addmodule_v2.diff ___ Python tracker

[issue27587] Issues, reported by PVS-Studio static analyzer

Stefan Krah added the comment: Sorry, I missed issue27587_pystate_addmodule.diff: no new issue in the updated analysis. -- ___ Python tracker ___

[issue27587] Issues, reported by PVS-Studio static analyzer

Stefan Krah added the comment: Pavel did another analysis with the external packages removed. Thanks for this! http://www.viva64.com/en/b/0418/ The new analysis found another glitch. Also see my message to python-committers. -- nosy: +skrah ___

[issue27587] Issues, reported by PVS-Studio static analyzer

Berker Peksag added the comment: I'm attaching Christian's patch at https://marc.info/?l=python-dev=146922730716425=2 as issue27587_pystate_addmodule.diff to make code reviewing easier. -- stage: needs patch -> patch review ___ Python tracker

[issue27587] Issues, reported by PVS-Studio static analyzer

Changes by Berker Peksag : -- keywords: +patch Added file: http://bugs.python.org/file43870/issue27587_pystate_addmodule.diff ___ Python tracker

[issue27587] Issues, reported by PVS-Studio static analyzer

Changes by Chris Angelico : -- nosy: +Rosuav ___ Python tracker ___ ___ Python-bugs-list

[issue27587] Issues, reported by PVS-Studio static analyzer

Christian Heimes added the comment: Hi Pavel, The issues in ASN1_PRINTABLE_type() [N2], BN_mask_bits() [N4 bn_lib.c, digest.c, evp_enc.c], dh_cms_set_peerkey() [N5, dh_ameth.c] and cms_env_set_version() [N6, cms_env.c] are all OpenSSL issues and should be reported to OpenSSL. The Windows build

[issue27587] Issues, reported by PVS-Studio static analyzer

Martin Panter added the comment: Also on python-dev, Chris Angelico pointed out that the _elementtree.c case is a false positive. So that would leave the binascii one, which I think is worth simpifying, but is probably not very serious. -- ___

[issue27587] Issues, reported by PVS-Studio static analyzer

Martin Panter added the comment: Christian Heimes posted a patch for _PyState_AddModule() on Python-dev: https://marc.info/?l=python-dev=146922730716425=2 -- ___ Python tracker

[issue27587] Issues, reported by PVS-Studio static analyzer

Berker Peksag added the comment: > V547 Expression 's->sock_fd < 0' is always false. Unsigned type value is > never < 0. Modules/socketmodule.c:655 > V547 Expression 's->sock_fd < 0' is always false. Unsigned type value is > never < 0. Modules/_ssl.c:1702 > V547 Expression 'sock->sock_fd < 0'

[issue27587] Issues, reported by PVS-Studio static analyzer

Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___

[issue27587] Issues, reported by PVS-Studio static analyzer

Martin Panter added the comment: Thanks for the report. You seem to have identified some code from Open SSL as being from Python (e.g. ASN1_PRINTABLE_type() function in a_print.c). Here’s a quick copy of the details relevant to Python: V547 Expression 's->sock_fd < 0' is always false.

[issue27587] Issues, reported by PVS-Studio static analyzer

New submission from Pavel Belikov: To demonstrate the capabilities of our analyzer, we regularly perform analysis of open source projects. We had recently checked the CPython project. Here is the link to the article about it: http://www.viva64.com/en/b/0414/ Official page of the analyzer: