[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Martin Panter added the comment: _freeze_import is only in Python 3, but I backported my final change because it is more general and also affects pgen. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Roundup Robot added the comment: New changeset e3757f3e1848 by Martin Panter in branch '2.7': Issue #27641: Comment out regeneration rules when cross compiling https://hg.python.org/cpython/rev/e3757f3e1848 -- ___ Python tracker

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Roundup Robot added the comment: New changeset bc677cb34889 by Martin Panter in branch '3.5': Issue #27641: Comment out regeneration rules when cross compiling https://hg.python.org/cpython/rev/bc677cb34889 New changeset fc034d3607a8 by Martin Panter in branch 'default': Issue #27641: Merge

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Martin Panter added the comment: Thanks for the feedback. I did wonder about the name. Perhaps I will go with GENERATED_COMMENT: GENERATED_COMMENT='#' Python/importlib_external.h: @GENERATED_COMMENT@ $(srcdir)/Lib/importlib/_bootstrap_external.py Programs/_freeze_importlib --

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Thomas Perl added the comment: +1 on comment-out-regen.patch, makes things much cleaner and removes the shell "if" in the rule body. Just a small bikeshed issue: Instead of COMMENT_REGEN, maybe call it "CROSS_COMPILE_COMMENT" or "GENERATED_COMMENT" or "COMMENT_IF_CROSS" or somesuch? This

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Xavier de Gaye added the comment: Nice. FWIW cross-compilation for Android works fine with comment-out-regen.patch. > In native compiling mode, everything should be as normal. When > cross-compiling, the rules for regenerating files should read like > > Python/importlib.h: #

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Changes by Xavier de Gaye : -- nosy: +xdegaye ___ Python tracker ___ ___ Python-bugs-list

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

Martin Panter added the comment: Here is another possible option. It is still a bit of a hack, because the configure script inserts comments into the makefile, but this is already done e.g. with @EXPORT_MACOSX_DEPLOYMENT_TARGET@. The advantage is we get to keep the filenames of the

[issue27641] Do not build Programs/_freeze_importlib when cross-compiling

New submission from Thomas Perl: Based on http://bugs.python.org/issue27490 and http://bugs.python.org/msg271495, here is a patch that makes sure Programs/_freeze_importlib is only built when not cross-compiling. -- components: Cross-Build files: